Skip to content

Commit 67a6850

Browse files
committed
fix connector definitions
1 parent 43e69d1 commit 67a6850

File tree

2 files changed

+34
-13
lines changed

2 files changed

+34
-13
lines changed

src/client.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ impl Client {
5555
if io.is_closed() {
5656
return Poll::Ready(());
5757
}
58-
if let Err(_) = read.poll_read_ready(cx) {
58+
if read.poll_read_ready(cx).is_err() {
5959
Poll::Ready(())
6060
} else {
6161
Poll::Pending

src/connector.rs

Lines changed: 33 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
use std::future::Future;
22

33
use ntex::connect::{self, Address, Connect, Connector};
4-
use ntex::io::{Io, IoBoxed};
4+
use ntex::io::{Filter, Io, IoBoxed};
55
use ntex::{service::Service, time::Seconds, util::ByteString, util::PoolId, util::PoolRef};
66

77
#[cfg(feature = "openssl")]
8-
use ntex::connect::openssl::{OpensslConnector, SslConnector};
8+
use ntex::connect::openssl::{self, SslConnector};
99

1010
#[cfg(feature = "rustls")]
11-
use ntex::connect::rustls::{ClientConfig, RustlsConnector};
11+
use ntex::connect::rustls::{self, ClientConfig};
1212

1313
use super::errors::ConnectError;
1414
use super::{cmd, Client, SimpleClient};
@@ -27,11 +27,16 @@ where
2727
{
2828
#[allow(clippy::new_ret_no_self)]
2929
/// Create new redis connector
30-
pub fn new(address: A) -> RedisConnector<A, Connector<A>> {
30+
pub fn new(
31+
address: A,
32+
) -> RedisConnector<
33+
A,
34+
impl Service<Request = Connect<A>, Response = IoBoxed, Error = connect::ConnectError>,
35+
> {
3136
RedisConnector {
3237
address,
3338
passwords: Vec::new(),
34-
connector: Connector::default(),
39+
connector: Connector::default().map(|io| io.into_boxed()),
3540
pool: PoolId::P7.pool_ref(),
3641
}
3742
}
@@ -62,12 +67,19 @@ where
6267
}
6368

6469
/// Use custom connector
65-
pub fn connector<U, F>(self, connector: U) -> RedisConnector<A, U>
70+
pub fn connector<U, F>(
71+
self,
72+
connector: U,
73+
) -> RedisConnector<
74+
A,
75+
impl Service<Request = Connect<A>, Response = IoBoxed, Error = connect::ConnectError>,
76+
>
6677
where
78+
F: Filter,
6779
U: Service<Request = Connect<A>, Response = Io<F>, Error = connect::ConnectError>,
6880
{
6981
RedisConnector {
70-
connector,
82+
connector: connector.map(|io| io.into_boxed()),
7183
address: self.address,
7284
passwords: self.passwords,
7385
pool: self.pool,
@@ -76,11 +88,17 @@ where
7688

7789
#[cfg(feature = "openssl")]
7890
/// Use openssl connector.
79-
pub fn openssl(self, connector: SslConnector) -> RedisConnector<A, OpensslConnector<A>> {
91+
pub fn openssl(
92+
self,
93+
connector: SslConnector,
94+
) -> RedisConnector<
95+
A,
96+
impl Service<Request = Connect<A>, Response = IoBoxed, Error = connect::ConnectError>,
97+
> {
8098
RedisConnector {
8199
address: self.address,
82100
passwords: self.passwords,
83-
connector: OpensslConnector::new(connector),
101+
connector: openssl::Connector::new(connector).map(|io| io.into_boxed()),
84102
pool: self.pool,
85103
}
86104
}
@@ -89,12 +107,15 @@ where
89107
/// Use rustls connector.
90108
pub fn rustls(
91109
self,
92-
config: std::sync::Arc<ClientConfig>,
93-
) -> RedisConnector<A, RustlsConnector<A>> {
110+
config: ClientConfig,
111+
) -> RedisConnector<
112+
A,
113+
impl Service<Request = Connect<A>, Response = IoBoxed, Error = connect::ConnectError>,
114+
> {
94115
RedisConnector {
95116
address: self.address,
96117
passwords: self.passwords,
97-
connector: RustlsConnector::new(config),
118+
connector: rustls::Connector::new(config).map(|io| io.into_boxed()),
98119
pool: self.pool,
99120
}
100121
}

0 commit comments

Comments
 (0)