Merge branch 'main' into add-claude-github-actions-1754887785091

Author: ntindle

.claude/settings.local.json

@@ -10,7 +10,9 @@
       "Bash(npm run build:*)",
       "Bash(npx vite build:*)",
       "Bash(npx vite:*)",
-      "Bash(npx tsc:*)"
+      "Bash(npx tsc:*)",
+      "Bash(gh pr view:*)",
+      "Bash(gh api:*)"
     ],
     "deny": []
   }

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,51 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: '[BUG] '
+labels: bug
+assignees: ''
+---
+
+## Describe the bug
+<!-- A clear and concise description of what the bug is -->
+
+## To Reproduce
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Enter dimensions '...'
+3. Select printer '...'
+4. Click on '...'
+5. See error
+
+## Expected behavior
+<!-- A clear and concise description of what you expected to happen -->
+
+## Actual behavior
+<!-- What actually happened instead -->
+
+## Screenshots
+<!-- If applicable, add screenshots to help explain your problem -->
+
+## Configuration
+<!-- Please provide the following information -->
+- Drawer dimensions: [e.g., 22.5" x 16.5" x 3"]
+- Unit system: [inches/millimeters]
+- Printer selected: [e.g., Prusa MK3S+, Custom]
+- Custom printer dimensions (if applicable): [e.g., 250mm x 210mm x 210mm]
+- Half-size bins enabled: [yes/no]
+- Number of drawers: [e.g., 1]
+
+## Browser Information
+<!-- Please complete the following information -->
+- Browser: [e.g., Chrome, Firefox, Safari]
+- Version: [e.g., 120.0]
+- Operating System: [e.g., Windows 11, macOS 14, Ubuntu 22.04]
+
+## Console Errors
+<!-- If there are any errors in the browser console, please paste them here -->
+```
+Paste any console errors here
+```
+
+## Additional context
+<!-- Add any other context about the problem here -->

.github/pull_request_template.md

@@ -0,0 +1,45 @@
+## Description
+<!-- Provide a brief description of the changes in this PR -->
+
+## Type of Change
+<!-- Mark the relevant option with an "x" -->
+- [ ] Bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+- [ ] Documentation update
+- [ ] Performance improvement
+- [ ] Code refactoring
+
+## Related Issue
+<!-- Link to the issue this PR addresses, if applicable -->
+Fixes #(issue number)
+
+## Changes Made
+<!-- List the specific changes made in this PR -->
+- 
+- 
+- 
+
+## Testing
+<!-- Describe the tests you ran to verify your changes -->
+- [ ] All existing tests pass
+- [ ] Added new tests for new functionality
+- [ ] Tested manually in browser
+- [ ] Tested with different drawer dimensions
+- [ ] Tested with custom printer settings
+- [ ] Tested with half-size bins enabled/disabled
+
+## Screenshots
+<!-- If applicable, add screenshots to help explain your changes -->
+
+## Checklist
+<!-- Mark completed items with an "x" -->
+- [ ] My code follows the project's code style guidelines
+- [ ] I have performed a self-review of my code
+- [ ] I have commented my code, particularly in hard-to-understand areas
+- [ ] I have made corresponding changes to the documentation
+- [ ] My changes generate no new warnings
+- [ ] I have added tests that prove my fix is effective or that my feature works
+- [ ] New and existing unit tests pass locally with my changes
+- [ ] I have used `unitMath` service for all calculations (no native JS math operations)
+- [ ] I have used `@/` import paths consistently

.github/workflows/deploy.yml

@@ -34,6 +34,9 @@ jobs:
             --severity=ERROR \
             --severity=WARNING \
             --severity=INFO \
+            --exclude=dist \
+            --exclude=node_modules \
+            --exclude=coverage \
             .
         continue-on-error: true
 
@@ -46,6 +49,9 @@ jobs:
             --severity=ERROR \
             --severity=WARNING \
             --severity=INFO \
+            --exclude=dist \
+            --exclude=node_modules \
+            --exclude=coverage \
             .
         continue-on-error: true
 

.github/workflows/sast.yml

@@ -0,0 +1,37 @@
+# Semgrep ignore file
+# https://semgrep.dev/docs/ignoring-files-folders-code/
+
+# Build artifacts
+dist/
+build/
+*.min.js
+*.bundle.js
+
+# Dependencies
+node_modules/
+vendor/
+
+# Test coverage
+coverage/
+.nyc_output/
+
+# IDE and editor files
+.vscode/
+.idea/
+*.swp
+*.swo
+
+# Temporary files
+tmp/
+temp/
+*.tmp
+
+# Generated files
+*.generated.*
+*-vendor-*.js
+
+# Package lock files (usually scanned separately)
+package-lock.json
+yarn.lock
+pnpm-lock.yaml
+bun.lockb

.semgrepignore

@@ -6,7 +6,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 Gridfinity Space Optimizer is a React-based web application for calculating optimal Gridfinity storage system layouts. It helps users determine the best configuration of Gridfinity bins to fit their drawer dimensions and 3D printer build volumes.
 
-## Recent Major Changes (Updated: Current Session)
+## Recent Major Changes (Updated: August 2025)
 
 ### ✅ MathJS Integration for Precision
 - **CRITICAL**: All calculations now use `unitMath` service (`src/services/unitMath.ts`) for BigNumber precision
@@ -29,7 +29,7 @@ Gridfinity Space Optimizer is a React-based web application for calculating opti
   - ✅ All test files migrated to TypeScript
   - ✅ Type definitions created for all core data structures
   - ✅ ESLint configured for TypeScript support
-  - ✅ All 168 tests passing
+  - ✅ All 187 tests passing
 - All console.log statements removed from production code
 - Import paths standardized to use `@/` alias consistently
 - ESLint configuration supports both TypeScript and JavaScript
@@ -67,7 +67,7 @@ npm run preview
 - **React Router** - Single-page routing
 - **Tailwind CSS** - Utility-first styling
 - **Shadcn/ui** - Component library built on Radix UI primitives
-- **React Query** - Server state management
+- **React Query** - Server state management (installed but not actively used)
 - **MathJS** - Arbitrary precision arithmetic
 
 ### Application Structure
@@ -94,6 +94,7 @@ The app follows a standard React SPA pattern with component-based architecture:
    - `PrinterSettings.tsx` - 3D printer selection with predefined build volumes
    - `BinOptions.tsx` - Toggle for half-size bin preferences
    - `DrawerOptions.tsx` - Number of identical drawers
+   - `CustomPrinterDialog.tsx` - Dialog for entering custom printer dimensions
 
 3. **Results Display**
    - `GridfinityResults.tsx` - Shows calculated bin quantities
@@ -138,7 +139,7 @@ Uses Shadcn/ui components (`src/components/ui/`) - pre-built accessible componen
 - **Testing**: Vitest test framework with React Testing Library
   - Run tests: `npm test`
   - Update snapshots: `npx vitest --run -u`
-  - 168 tests currently passing
+  - 187 tests currently passing
 - ESLint configured for TypeScript/TSX and JavaScript/JSX with max warnings set to 0
 - Development server runs on port 8080 (configured in vite.config.js)
 - Uses Vite's hot module replacement for rapid development
@@ -155,14 +156,15 @@ Uses Shadcn/ui components (`src/components/ui/`) - pre-built accessible componen
 - `usePersistedState` - Generic hook for localStorage persistence
 - `useLegacyMigration` - Handles migration from old localStorage format
 - `useCustomPrinter` - Manages custom printer dimensions
+- `use-toast` - Toast notification system
 
 ## Current Refactor Status
 
 See `REFACTOR_PLAN.md` for details:
 - ✅ Phase 1: Clean Up & Stabilize - COMPLETED
 - ✅ Phase 2: State Management - COMPLETED
 - ✅ Phase 3: Feature Enhancements - COMPLETED
-- ⏸️ Phase 4: Architecture with TypeScript - IN PROGRESS
+- ✅ Phase 4: Architecture with TypeScript - COMPLETED
 - ❌ Phase 5-6: Not started yet
 
 See `docs/REFACTOR_PLAN_MATHJS.md` for MathJS integration:
@@ -215,4 +217,10 @@ import { something } from '@/lib/utils';
 
 1. **Memory issues during tests**: Tests sometimes run out of memory due to large calculations
 2. **Snapshot tests**: Will fail when precision calculations change - update with `npx vitest --run -u`
-3. **localStorage migration**: Legacy settings are migrated on first load - don't break this!
+3. **localStorage migration**: Legacy settings are migrated on first load - don't break this!
+- Always add tests for new features or changes to the algorithms
+
+## GitHub Templates
+
+- **Pull Request Template**: `.github/pull_request_template.md` - Standardized PR checklist
+- **Bug Report Template**: `.github/ISSUE_TEMPLATE/bug_report.md` - Structured bug reporting format

CLAUDE.md

@@ -76,6 +76,9 @@ describe('GridfinityCalculator', () => {
     await userEvent.clear(widthInput);
     await userEvent.type(widthInput, '20');
 
+    // Trigger blur to save the value
+    await userEvent.tab();
+    
     await waitFor(() => {
       expect(vi.mocked(saveUserSettings).mock.calls.length).toBeGreaterThan(initialCallCount);
     });
@@ -187,6 +190,9 @@ describe('GridfinityCalculator', () => {
     await userEvent.clear(heightInput);
     await userEvent.type(heightInput, '25');
 
+    // Trigger blur to save the value
+    await userEvent.tab();
+    
     await waitFor(() => {
       expect(vi.mocked(saveUserSettings).mock.calls.length).toBeGreaterThan(initialSaveCount);
       const lastCall = vi.mocked(saveUserSettings).mock.calls[vi.mocked(saveUserSettings).mock.calls.length - 1][0];

src/components/GridfinityCalculator.test.tsx

@@ -25,6 +25,7 @@ const GridfinityCalculator: React.FC = () => {
     customPrinterSize: settings.customPrinterSize,
     useHalfSize: settings.useHalfSize,
     preferHalfSize: settings.preferHalfSize,
+    preferUniformBaseplates: settings.preferUniformBaseplates,
     numDrawers: settings.numDrawers,
   });
 
@@ -102,6 +103,8 @@ const GridfinityCalculator: React.FC = () => {
               setUseHalfSize={settings.setUseHalfSize}
               preferHalfSize={settings.preferHalfSize}
               setPreferHalfSize={settings.setPreferHalfSize}
+              preferUniformBaseplates={settings.preferUniformBaseplates}
+              setPreferUniformBaseplates={settings.setPreferUniformBaseplates}
             />
           </CardContent>
         </Card>

src/components/GridfinityCalculator.tsx

@@ -7,6 +7,8 @@ const BinOptions = ({
   setUseHalfSize,
   preferHalfSize,
   setPreferHalfSize,
+  preferUniformBaseplates,
+  setPreferUniformBaseplates,
 }) => {
   return (
     <div className="space-y-6 p-4">
@@ -38,6 +40,16 @@ const BinOptions = ({
             }}
           />
         </div>
+        <div className="flex items-center justify-between">
+          <Label htmlFor="prefer-uniform-baseplates" className="flex-1">
+            Prefer uniform baseplate sizes
+          </Label>
+          <Switch
+            id="prefer-uniform-baseplates"
+            checked={preferUniformBaseplates}
+            onCheckedChange={setPreferUniformBaseplates}
+          />
+        </div>
       </div>
     </div>
   );