Add a validate_handler macro that checks handlers for the mode enums

Author: frmdstryr

atom/src/behaviors.h

@@ -205,8 +205,28 @@ enum Mode: uint8_t
     Property,
     ObjectMethod_Name,
     MemberMethod_Object,
+    Last // sentinel
 };
 
 }  // namespace GetState
 
+constexpr uint8_t _required_handler_size(uint8_t x) {
+    return (
+        (x > 128) ? 255 :
+        (x > 64) ? 128 :
+        (x > 32) ? 64 :
+        (x > 16) ? 32 :
+        (x > 8) ? 16 :
+        (x > 4) ? 8 :
+        (x > 2) ? 4 :
+        2
+    );
+}
+
+#define _handlers_size( a ) ( sizeof(a) / sizeof(a[0]) )
+#define validate_handlers( handlers, sentinel ) \
+    _handlers_size(handlers) - 1; \
+    static_assert(sentinel <= _handlers_size(handlers), "Not enough handlers for all enum values"); \
+    static_assert(_required_handler_size(sentinel) == _handlers_size(handlers), "Handlers size does not match enum width") \
+
 }  // namespace atom

atom/src/defaultvaluebehavior.cpp

@@ -207,15 +207,15 @@ handlers[] = {
     no_op_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 16, "Must be exactly 16 handlers" );
+const auto mask = validate_handlers(handlers, DefaultValue::Mode::Last);
 
 }  // namespace
 
 
 PyObject*
 Member::default_value( CAtom* atom )
 {
-    return handlers[ get_default_value_mode() & 0xf ]( this, atom );
+    return handlers[ get_default_value_mode() & mask ]( this, atom );
 }
 
 

atom/src/delattrbehavior.cpp

@@ -192,15 +192,15 @@ handlers[] = {
     property_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 8, "Must be exactly 8 handlers" );
+const auto mask = validate_handlers(handlers, DelAttr::Mode::Last);
 
 }  // namespace
 
 
 int
 Member::delattr( CAtom* atom )
 {
-    return handlers[ get_delattr_mode() & 0x7 ]( this, atom );
+    return handlers[ get_delattr_mode() & mask ]( this, atom );
 }
 
 

atom/src/getattrbehavior.cpp

@@ -263,15 +263,15 @@ handlers[] = {
     no_op_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 16, "Must be exactly 16 handlers" );
+const auto mask = validate_handlers(handlers, GetAttr::Mode::Last);
 
 }  // namespace
 
 
 PyObject*
 Member::getattr( CAtom* atom )
 {
-    return handlers[ get_getattr_mode() & 0xf ]( this, atom );
+    return handlers[ get_getattr_mode() & mask ]( this, atom );
 }
 
 }  // namespace atom

atom/src/getstatebehavior.cpp

@@ -129,15 +129,15 @@ handlers[] = {
     include_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 8, "Must be exactly 8 handlers" );
+const auto mask = validate_handlers(handlers, GetState::Mode::Last);
 
 }  // namespace
 
 
 PyObject*
 Member::should_getstate( CAtom* atom )
 {
-    return handlers[ get_getstate_mode() & 0x7 ]( this, atom );
+    return handlers[ get_getstate_mode() & mask ]( this, atom );
 }
 
 }  // namespace atom

atom/src/postgetattrbehavior.cpp

@@ -99,15 +99,15 @@ handlers[] = {
     no_op_handler,
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 8, "Must be exactly 8 handlers" );
+const auto mask = validate_handlers(handlers, PostGetAttr::Mode::Last);
 
 }  // namespace
 
 
 PyObject*
 Member::post_getattr( CAtom* atom, PyObject* value )
 {
-    return handlers[ get_post_getattr_mode() & 0x7 ]( this, atom, value );
+    return handlers[ get_post_getattr_mode() & mask ]( this, atom, value );
 }
 
 

atom/src/postsetattrbehavior.cpp

@@ -112,15 +112,15 @@ handlers[] = {
     no_op_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 8, "Must be exactly 8 handlers" );
+const auto mask = validate_handlers(handlers, PostSetAttr::Mode::Last);
 
 }  // namespace
 
 
 int
 Member::post_setattr( CAtom* atom, PyObject* oldvalue, PyObject* newvalue )
 {
-    return handlers[ get_post_setattr_mode() & 0x7 ]( this, atom, oldvalue, newvalue );
+    return handlers[ get_post_setattr_mode() & mask ]( this, atom, oldvalue, newvalue );
 }
 
 

atom/src/postvalidatebehavior.cpp

@@ -103,15 +103,15 @@ handlers[] = {
     no_op_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 8, "Must be exactly 8 handlers" );
+const auto mask = validate_handlers(handlers, PostValidate::Mode::Last);
 
 }  // namespace
 
 
 PyObject*
 Member::post_validate( CAtom* atom, PyObject* oldvalue, PyObject* newvalue )
 {
-    return handlers[ get_post_validate_mode() & 0x7 ]( this, atom, oldvalue, newvalue );
+    return handlers[ get_post_validate_mode() & mask ]( this, atom, oldvalue, newvalue );
 }
 
 }  // namespace atom

atom/src/setattrbehavior.cpp

@@ -383,15 +383,15 @@ handlers[] = {
     no_op_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 16, "Must be exactly 16 handlers" );
+const auto mask = validate_handlers(handlers, SetAttr::Mode::Last);
 
 } // namespace
 
 
 int
 Member::setattr( CAtom* atom, PyObject* value )
 {
-    return handlers[ get_setattr_mode() & 0xf ]( this, atom, value );
+    return handlers[ get_setattr_mode() & mask ]( this, atom, value );
 }
 
 

atom/src/validatebehavior.cpp

@@ -1000,16 +1000,15 @@ handlers[] = {
     member_method_object_old_new_handler
 };
 
+const auto mask = validate_handlers(handlers, Validate::Mode::Last);
 
 }  // namespace
 
 
 PyObject*
 Member::validate( CAtom* atom, PyObject* oldvalue, PyObject* newvalue )
 {
-    if( get_validate_mode() >= sizeof( handlers ) / sizeof( handler ) )
-        return no_op_handler( this, atom, oldvalue, newvalue );  // LCOV_EXCL_LINE
-    return handlers[ get_validate_mode() ]( this, atom, oldvalue, newvalue );
+    return handlers[ get_validate_mode() & mask ]( this, atom, oldvalue, newvalue );
 }