Skip to content

Commit 78999bb

Browse files
ci: use legacy command to install to measure properly coverage of C++ extension
1 parent dfd765c commit 78999bb

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,16 +88,22 @@ jobs:
8888
if: matrix.python-version != '3.10'
8989
env:
9090
CPPFLAGS: --coverage
91-
# Build extensions manually to allow getting C coverage data
91+
# Use legacy command to install the library to be able to measure
92+
# coverage of C++ code.
9293
run: |
93-
pip install -e .[qt${{ matrix.qt-version }}-${{ matrix.qt-binding }}]
94+
pip install .[qt${{ matrix.qt-version }}-${{ matrix.qt-binding }}]
95+
pip uninstall enaml
96+
python setup.py develop
9497
- name: Install project (with-extras pyqt)
9598
if: matrix.python-version == '3.10' && matrix.qt-binding == 'pyqt'
9699
env:
97100
CPPFLAGS: --coverage
98-
# Build extensions manually to allow getting C coverage data
101+
# Use legacy command to install the library to be able to measure
102+
# coverage of C++ code.
99103
run: |
100-
pip install -e .[qt${{ matrix.qt-version }}-${{ matrix.qt-binding }},ipython-qt,matplotlib-qt,scintilla-qt${{ matrix.qt-version }}-pyqt,webview-qt${{ matrix.qt-version }}-pyqt]
104+
pip install .[qt${{ matrix.qt-version }}-${{ matrix.qt-binding }},ipython-qt,matplotlib-qt,scintilla-qt${{ matrix.qt-version }}-pyqt,webview-qt${{ matrix.qt-version }}-pyqt]
105+
pip uninstall enaml
106+
python setup.py develop
101107
- name: Install project (with-extras pyside)
102108
if: matrix.python-version == '3.10' && matrix.qt-binding != 'pyqt'
103109
env:
@@ -136,4 +142,3 @@ jobs:
136142
name: codecov-umbrella
137143
fail_ci_if_error: true
138144
verbose: true
139-
files: ./coverage.xml,*.gcov

0 commit comments

Comments
 (0)