-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Overview
The signing module currently uses console.error for error logging, which is not ideal for production code. This should be replaced with a proper error handling mechanism that doesn't output to console in production environments.
Current Behavior
In packages/taco/src/sign.ts:157-160, there's a console.error statement:
console.error(
'Porter returned mismatched message hashes:',
hashToSignatures,
);Expected Behavior
- Remove the console.error statement
- The error information should be included in the thrown error or handled through a proper logging mechanism
- Consider including the mismatched hashes information in the error message itself
Files to Change
packages/taco/src/sign.ts(line 157-160)
Implementation Suggestions
- Include the debug information in the error message that's thrown
- Consider creating a debug mode flag that conditionally logs verbose information
- Ensure sensitive information isn't exposed in error messages
Definition of Done
- console.error removed from the code
- Error information is still accessible for debugging
- Tests still pass
- No console output in production builds
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers