Add more test cases

Author: Jin Huang

zendesk/group_test.go

@@ -6,7 +6,7 @@ import (
 	"testing"
 )
 
-func TestGetGroups(t *testing.T) {
+func TestGetGroupsIterator(t *testing.T) {
 	mockAPI := newMockAPI(http.MethodGet, "groups.json")
 	client := newTestClient(mockAPI)
 	defer mockAPI.Close()
@@ -17,23 +17,23 @@ func TestGetGroups(t *testing.T) {
 	it := client.GetGroupsIterator(ctx, ops)
 
 	expectedLength := 1
+	groupsCount := 0
 	for it.HasMore() {
 		groups, err := it.GetNext()
 		if len(groups) != expectedLength {
 			t.Fatalf("expected length of groups is 1, but got %d", len(groups))
 		}
-		if err == nil {
-			for _, group := range groups {
-				println(group.Name)
-			}
-		}
+		groupsCount += len(groups)
 		if err != nil {
 			t.Fatalf("Failed to get groups: %s", err)
 		}
 	}
+	if groupsCount != 1 {
+		t.Fatalf("expected length of groups is 1, but got %d", groupsCount)
+	}
 }
 
-func TestGetGroupsIterator(t *testing.T) {
+func TestGetGroups(t *testing.T) {
 	mockAPI := newMockAPI(http.MethodGet, "groups.json")
 	client := newTestClient(mockAPI)
 	defer mockAPI.Close()
@@ -48,6 +48,36 @@ func TestGetGroupsIterator(t *testing.T) {
 	}
 }
 
+func TestGetGroupsOBP(t *testing.T) {
+	mockAPI := newMockAPI(http.MethodGet, "groups.json")
+	client := newTestClient(mockAPI)
+	defer mockAPI.Close()
+
+	groups, _, err := client.GetGroupsOBP(ctx, nil)
+	if err != nil {
+		t.Fatalf("Failed to get groups: %s", err)
+	}
+
+	if len(groups) != 1 {
+		t.Fatalf("expected length of groups is 1, but got %d", len(groups))
+	}
+}
+
+func TestGetGroupsCBP(t *testing.T) {
+	mockAPI := newMockAPI(http.MethodGet, "groups.json")
+	client := newTestClient(mockAPI)
+	defer mockAPI.Close()
+
+	groups, _, err := client.GetGroupsCBP(ctx, nil)
+	if err != nil {
+		t.Fatalf("Failed to get groups: %s", err)
+	}
+
+	if len(groups) != 1 {
+		t.Fatalf("expected length of groups is 1, but got %d", len(groups))
+	}
+}
+
 func TestCreateGroup(t *testing.T) {
 	mockAPI := newMockAPIWithStatus(http.MethodPost, "groups.json", http.StatusCreated)
 	client := newTestClient(mockAPI)

zendesk/ticket_test.go

@@ -127,6 +127,58 @@ func TestGetOrganizationTickets(t *testing.T) {
 	}
 }
 
+func TestGetOrganizationTicketsOBP(t *testing.T) {
+	mockAPI := newMockAPI(http.MethodGet, "tickets.json")
+	client := newTestClient(mockAPI)
+	defer mockAPI.Close()
+
+	tickets, _, err := client.GetOrganizationTicketsOBP(ctx, &OBPOptions{
+		PageOptions: PageOptions{
+			Page:    1,
+			PerPage: 10,
+		},
+		CommonOptions: CommonOptions{
+			SortBy:    "created_at",
+			SortOrder: "asc",
+			Id:        360363695492,
+		},
+	})
+	if err != nil {
+		t.Fatalf("Failed to get tickets: %s", err)
+	}
+
+	expectedLength := 2
+	if len(tickets) != expectedLength {
+		t.Fatalf("Returned tickets does not have the expected length %d. Tickets length is %d", expectedLength, len(tickets))
+	}
+}
+
+func TestGetOrganizationTicketsCBP(t *testing.T) {
+	mockAPI := newMockAPI(http.MethodGet, "tickets.json")
+	client := newTestClient(mockAPI)
+	defer mockAPI.Close()
+
+	tickets, _, err := client.GetOrganizationTicketsCBP(ctx, &CBPOptions{
+		CursorPagination: CursorPagination{
+			PageSize:  10,
+			PageAfter: "",
+		},
+		CommonOptions: CommonOptions{
+			SortBy:    "created_at",
+			SortOrder: "asc",
+			Id:        360363695492,
+		},
+	})
+	if err != nil {
+		t.Fatalf("Failed to get tickets: %s", err)
+	}
+
+	expectedLength := 2
+	if len(tickets) != expectedLength {
+		t.Fatalf("Returned tickets does not have the expected length %d. Tickets length is %d", expectedLength, len(tickets))
+	}
+}
+
 func TestGetOrganizationTicketsIterator(t *testing.T) {
 	mockAPI := newMockAPI(http.MethodGet, "tickets.json")
 	client := newTestClient(mockAPI)