fix: Windows build

Author: nullableVoidPtr

.github/workflows/build.yaml

@@ -0,0 +1,62 @@
+name: Build
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+  workflow_dispatch:
+
+env:
+  BUILD_TYPE: RelWithDebInfo
+
+jobs:
+  build:
+    runs-on: ${{matrix.config.os}}
+    strategy:
+      matrix:
+        config:
+        - {
+            os: windows-2019,
+            name: windows
+          }
+        - {
+            os: macos-13,
+            name: macos
+          }
+        - {
+            os: ubuntu-22.04,
+            name: ubuntu
+          }
+        version:
+        - name: v5.0.7290-stable
+          use-patch: false
+        - name: dev
+          use-patch: false
+    steps:
+    - uses: actions/checkout@v3
+      with:
+        submodules: 'true'
+    - uses: seanmiddleditch/gha-setup-ninja@master
+    - uses: ilammy/msvc-dev-cmd@v1
+    - name: Update submodule
+      run: |
+        cd binaryninjaapi
+        git fetch --tags
+        git checkout --force ${{matrix.version.name}}
+        git submodule update --init --recursive
+    - name: Patch api to allow building headlessly
+      if: ${{ matrix.version.use-patch }}
+      shell: bash
+      run: |
+        cd binaryninjaapi
+        git apply --verbose ${{matrix.version.patch-file}} 
+    - name: Configure CMake
+      run: cmake -B ${{github.workspace}}/build -G Ninja -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
+    - name: Build
+      run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}
+    - name: Upload artifact
+      uses: actions/upload-artifact@v4
+      with:
+        name: ${{matrix.config.name}}-${{matrix.version.name}}
+        path: ${{github.workspace}}/build/libarch_arcompact.so

.gitignore

@@ -43,4 +43,6 @@ compile_commands.json
 CTestTestfile.cmake
 _deps
 
-api/
+api/
+build/
+.cache/

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "binaryninjaapi"]
+	path = binaryninjaapi
+	url = https://github.com/Vector35/binaryninja-api

CMakeLists.txt

@@ -10,6 +10,7 @@ file(GLOB SOURCES
 
 add_library(${PROJECT_NAME} SHARED ${SOURCES})
 
+set(HEADLESS 1)
 find_path(
     BN_API_PATH
     NAMES binaryninjaapi.h
@@ -25,7 +26,7 @@ target_include_directories(${PROJECT_NAME}
 target_link_libraries(${PROJECT_NAME} binaryninjaapi)
 
 set_target_properties(${PROJECT_NAME} PROPERTIES
-    CXX_STANDARD 17
+    CXX_STANDARD 20
 	CXX_VISIBILITY_PRESET hidden
 	CXX_STANDARD_REQUIRED ON
 	C_STANDARD 99
@@ -34,4 +35,4 @@ set_target_properties(${PROJECT_NAME} PROPERTIES
     VISIBILITY_INLINES_HIDDEN ON
 	POSITION_INDEPENDENT_CODE ON)
 
-bn_install_plugin(${PROJECT_NAME})
+bn_install_plugin(${PROJECT_NAME})

arch_arcompact.cpp

@@ -452,7 +452,7 @@ class ArcArchitecture : public Architecture {
 			case ARC_NEGS:
 			case ARC_NORM:
 				if (instruction.data_size) {
-					strncat(operation, (instruction.data_size == BYTE) ? "b" : "w", 1);
+					strncat(operation, (instruction.data_size == BYTE_8) ? "b" : "w", 1);
 					bytes_left -= 1;
 				}
 			default:
@@ -712,6 +712,10 @@ class ArcCallingConvention: public CallingConvention {
 extern "C" {
 	BN_DECLARE_CORE_ABI_VERSION
 
+	BINARYNINJAPLUGIN void CorePluginDependencies() {
+		AddOptionalPluginDependency("view_elf");
+	}
+
 	BINARYNINJAPLUGIN bool CorePluginInit() {
 		Architecture* a5el = new ArcArchitecture("arctangent-a5", ARC_TANGENT_A5, LittleEndian);
 		Architecture* a5eb = new ArcArchitecture("arctangent-a5eb", ARC_TANGENT_A5, BigEndian);
@@ -729,6 +733,7 @@ extern "C" {
 
 		ArcCallingConvention* o32LE = new ArcCallingConvention(arc600eb);
 
+		BinaryViewType::RegisterArchitecture("ELF", 0x5d, LittleEndian, a5el);
 
 		// TODO bvtype register
 		return true;