Skip to content

Commit 2ce9d53

Browse files
author
nullccxsy
committed
fix comments
1 parent 2fb136e commit 2ce9d53

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/iceberg/type.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,13 @@ class ICEBERG_EXPORT PrimitiveType : public Type {
7070

7171
/// \brief A data type that has child fields.
7272
class ICEBERG_EXPORT NestedType : public Type {
73-
protected:
74-
using SchemaFieldConstRef = std::reference_wrapper<const SchemaField>;
75-
7673
public:
7774
bool is_primitive() const override { return false; }
7875
bool is_nested() const override { return true; }
7976

8077
/// \brief Get a view of the child fields.
8178
[[nodiscard]] virtual std::span<const SchemaField> fields() const = 0;
79+
using SchemaFieldConstRef = std::reference_wrapper<const SchemaField>;
8280
/// \brief Get a field by field ID.
8381
///
8482
/// \note This is O(1) complexity.
@@ -132,7 +130,6 @@ class ICEBERG_EXPORT StructType : public NestedType {
132130
Status InitFieldByName() const;
133131
Status InitFieldByLowerCaseName() const;
134132

135-
protected:
136133
std::vector<SchemaField> fields_;
137134
mutable std::unordered_map<int32_t, SchemaFieldConstRef> field_by_id_;
138135
mutable std::unordered_map<std::string_view, SchemaFieldConstRef> field_by_name_;

0 commit comments

Comments
 (0)