Skip to content

Commit 43c8560

Browse files
author
nullccxsy
committed
refactor: remove unused arrow_c_data_internal files
- Delete unused nanoarrow example code and test files - Clean up dependencies and remove obsolete test cases
1 parent 4ab42c4 commit 43c8560

File tree

4 files changed

+0
-149
lines changed

4 files changed

+0
-149
lines changed

src/iceberg/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
set(ICEBERG_INCLUDES "$<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/src>"
1919
"$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/src>")
2020
set(ICEBERG_SOURCES
21-
arrow_c_data_internal.cc
2221
catalog/in_memory_catalog.cc
2322
expression/expression.cc
2423
expression/literal.cc

src/iceberg/arrow_c_data_internal.cc

Lines changed: 0 additions & 81 deletions
This file was deleted.

src/iceberg/arrow_c_data_internal.h

Lines changed: 0 additions & 33 deletions
This file was deleted.

test/arrow_test.cc

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -28,46 +28,12 @@
2828
#include <arrow/util/key_value_metadata.h>
2929
#include <gtest/gtest.h>
3030

31-
#include "iceberg/arrow_c_data_internal.h"
3231
#include "iceberg/schema.h"
3332
#include "iceberg/schema_internal.h"
3433
#include "matchers.h"
3534

3635
namespace iceberg {
3736

38-
TEST(ArrowCDataTest, CheckArrowSchemaAndArrayByNanoarrow) {
39-
auto [schema, array] = internal::CreateExampleArrowSchemaAndArrayByNanoarrow();
40-
41-
auto arrow_schema = ::arrow::ImportSchema(&schema).ValueOrDie();
42-
EXPECT_EQ(arrow_schema->num_fields(), 2);
43-
44-
auto id_field = arrow_schema->field(0);
45-
EXPECT_EQ(id_field->name(), "id");
46-
EXPECT_EQ(id_field->type()->id(), ::arrow::Type::INT64);
47-
EXPECT_FALSE(id_field->nullable());
48-
49-
auto name_field = arrow_schema->field(1);
50-
EXPECT_EQ(name_field->name(), "name");
51-
EXPECT_EQ(name_field->type()->id(), ::arrow::Type::STRING);
52-
EXPECT_TRUE(name_field->nullable());
53-
54-
auto arrow_record_batch = ::arrow::ImportRecordBatch(&array, arrow_schema).ValueOrDie();
55-
EXPECT_EQ(arrow_record_batch->num_rows(), 3);
56-
EXPECT_EQ(arrow_record_batch->num_columns(), 2);
57-
58-
auto id_column = arrow_record_batch->column(0);
59-
EXPECT_EQ(id_column->type()->id(), ::arrow::Type::INT64);
60-
EXPECT_EQ(id_column->GetScalar(0).ValueOrDie()->ToString(), "1");
61-
EXPECT_EQ(id_column->GetScalar(1).ValueOrDie()->ToString(), "2");
62-
EXPECT_EQ(id_column->GetScalar(2).ValueOrDie()->ToString(), "3");
63-
64-
auto name_column = arrow_record_batch->column(1);
65-
EXPECT_EQ(name_column->type()->id(), ::arrow::Type::STRING);
66-
EXPECT_EQ(name_column->GetScalar(0).ValueOrDie()->ToString(), "a");
67-
EXPECT_EQ(name_column->GetScalar(1).ValueOrDie()->ToString(), "b");
68-
EXPECT_EQ(name_column->GetScalar(2).ValueOrDie()->ToString(), "c");
69-
}
70-
7137
struct ToArrowSchemaParam {
7238
std::shared_ptr<Type> iceberg_type;
7339
bool optional = true;

0 commit comments

Comments
 (0)