Merge pull request lukeleppan#121 from NullCub3/fix-null-setting-values

Prevent Null Setting Values

Author: lukeleppan

src/settings/SettingsTab.ts

@@ -53,28 +53,37 @@ export default class BetterWordCountSettingsTab extends PluginSettingTab {
       .setDesc("Set how many words count as one \"page\"")
       .addText((text: TextComponent) => {
         text.inputEl.type = "number";
-        text.setPlaceholder("300");
-        text.setValue(this.plugin.settings.pageWords.toString());
-        text.onChange(async (value: string) => {
-          this.plugin.settings.pageWords = parseInt(value);
-          await this.plugin.saveSettings();
+        text
+          .setPlaceholder("300")
+          .setValue(String(this.plugin.settings.pageWords))
+          .onChange(async (value: string) => {
+            if (value) {
+              this.plugin.settings.pageWords = parseInt(value);
+            } else {
+              this.plugin.settings.pageWords = 300;
+            }
+            await this.plugin.saveSettings();
+          });
       });
-    });
 
     // Advanced Settings
     containerEl.createEl("h4", { text: "Advanced Settings" });
     new Setting(containerEl)
       .setName("Vault Stats File Path")
       .setDesc("Reload required for change to take effect. The location of the vault statistics file, relative to the vault root.")
       .addText((text: TextComponent) => {
-        text.setPlaceholder(".obsidian/vault-stats.json");
-        text.setValue(this.plugin.settings.statsPath.toString());
-        text.onChange(async (value: string) => {
-          this.plugin.settings.statsPath = value;
-          await this.plugin.saveSettings();
+        text
+          .setPlaceholder(".obsidian/vault-stats.json")
+          .setValue(this.plugin.settings.statsPath)
+          .onChange(async (value: string) => {
+            if (value) {
+              this.plugin.settings.statsPath = value;
+            } else {
+              this.plugin.settings.statsPath = ".obsidian/vault-stats.json";
+            }
+            await this.plugin.saveSettings();
+          });
       });
-    });
-
 
     // Status Bar Settings
     addStatusBarSettings(this.plugin, containerEl);