chore: variable renames

Author: ProgrammingByPermutation

src/Nullinside.Api.TwitchBot/Bots/ABotRule.cs

@@ -68,7 +68,7 @@ where string.Equals(bannedUsers.ChannelId, channelId) &&
 
     // Perform the ban and get the list of people actually banned
     IEnumerable<BannedUser> confirmedBans =
-      await botProxy.BanChannelUsers(channelId, Constants.BotId, bansToTry, reason, stoppingToken);
+      await botProxy.BanChannelUsers(channelId, Constants.BOT_ID, bansToTry, reason, stoppingToken);
 
     await db.SaveTwitchBans(channelId, users, reason, stoppingToken);
     return confirmedBans;

src/Nullinside.Api.TwitchBot/ChatRules/AChatRule.cs

@@ -29,7 +29,7 @@ public abstract Task<bool> Handle(string channelId, ITwitchApiProxy botProxy, Tw
   public async Task BanAndLog(string channelId, ITwitchApiProxy botProxy,
     IEnumerable<(string Id, string Username)> users, string reason, INullinsideContext db,
     CancellationToken stoppingToken = new()) {
-    await botProxy.BanChannelUsers(channelId, Constants.BotId, users, reason, stoppingToken);
+    await botProxy.BanChannelUsers(channelId, Constants.BOT_ID, users, reason, stoppingToken);
     await db.SaveTwitchBans(channelId, users, reason, stoppingToken);
   }
 }

src/Nullinside.Api.TwitchBot/ChatRules/BestCheapViewers.cs

@@ -13,7 +13,7 @@ public class BestCheapViewers : AChatRule {
   /// <summary>
   ///   The strings that we expect to receive if this is a bot.
   /// </summary>
-  public readonly string[] EXPECTED = [
+  public readonly string[] Expected = [
     "best viewers on",
     "cheap viewers on",
     "cheap folloewrs on",
@@ -39,7 +39,7 @@ public override async Task<bool> Handle(string channelId, ITwitchApiProxy botPro
     // Messages will be one of two variations with random special characters mixed in. Some of those special characters
     // will be accent marks. When we receive an accent mark it'll take the position of a real character, hence why we
     // need an offset applied only to the incoming string.
-    foreach (string expected in EXPECTED) {
+    foreach (string expected in Expected) {
       if (normalized.Length > expected.Length) {
         int matches = 0;
         int offset = 0;

src/Nullinside.Api.TwitchBot/ChatRules/Discord.cs

@@ -10,7 +10,7 @@ namespace Nullinside.Api.TwitchBot.ChatRules;
 ///   Handles the add me on discord bots.
 /// </summary>
 public class Discord : AChatRule {
-  private readonly string[] KNOWN_PHRASES = [
+  private readonly string[] _knownPhrases = [
     "add me",
     "add my",
     "add up",
@@ -45,7 +45,7 @@ public override async Task<bool> Handle(string channelId, ITwitchApiProxy botPro
       return true;
     }
 
-    foreach (string phrase in KNOWN_PHRASES) {
+    foreach (string phrase in _knownPhrases) {
       if (normalized.Contains(phrase, StringComparison.InvariantCultureIgnoreCase)) {
         await BanAndLog(channelId, botProxy, new[] { (message.UserId, message.Username) },
           "[Bot] Spam (Discord Scammers)", db, stoppingToken);

src/Nullinside.Api.TwitchBot/ChatRules/IfYouWantViewers.cs

@@ -13,7 +13,7 @@ public class IfYouWantViewers : AChatRule {
   /// <summary>
   ///   The strings that we expect to receive if this is a bot.
   /// </summary>
-  public readonly string[] EXPECTED = [
+  public readonly string[] Expected = [
     "if you want more viewers for your stream, go to"
   ];
 
@@ -33,7 +33,7 @@ public override async Task<bool> Handle(string channelId, ITwitchApiProxy botPro
     string normalized = string.Join(' ', message.Message.Split(" ").Where(s => !string.IsNullOrWhiteSpace(s)))
       .ToLowerInvariant();
 
-    foreach (string expected in EXPECTED) {
+    foreach (string expected in Expected) {
       if (normalized.Contains(expected, StringComparison.InvariantCultureIgnoreCase)) {
         await BanAndLog(channelId, botProxy, new[] { (message.UserId, message.Username) },
           "[Bot] Spam (If You Want Viewers)", db, stoppingToken);

src/Nullinside.Api.TwitchBot/ChatRules/Naked.cs

@@ -10,8 +10,8 @@ namespace Nullinside.Api.TwitchBot.ChatRules;
 ///   Handles the want to see her naked porn bots.
 /// </summary>
 public class Naked : AChatRule {
-  private const string _spam = "Want to see her naked?";
-  private const string _spam2 = "Want to see me naked?";
+  private const string SPAM = "Want to see her naked?";
+  private const string SPAM2 = "Want to see me naked?";
 
   /// <inheritdoc />
   public override bool ShouldRun(TwitchUserConfig config) {
@@ -22,8 +22,8 @@ public override bool ShouldRun(TwitchUserConfig config) {
   public override async Task<bool> Handle(string channelId, ITwitchApiProxy botProxy, TwitchChatMessage message,
     INullinsideContext db, CancellationToken stoppingToken = new()) {
     if (message.IsFirstMessage &&
-        (message.Message.TrimStart().StartsWith(_spam, StringComparison.InvariantCultureIgnoreCase) ||
-         message.Message.TrimStart().StartsWith(_spam2, StringComparison.InvariantCultureIgnoreCase))) {
+        (message.Message.TrimStart().StartsWith(SPAM, StringComparison.InvariantCultureIgnoreCase) ||
+         message.Message.TrimStart().StartsWith(SPAM2, StringComparison.InvariantCultureIgnoreCase))) {
       await BanAndLog(channelId, botProxy, new[] { (message.UserId, message.Username) },
         "[Bot] Spam (Naked)", db, stoppingToken);
       return false;

src/Nullinside.Api.TwitchBot/ChatRules/StreamRise.cs

@@ -10,7 +10,7 @@ namespace Nullinside.Api.TwitchBot.ChatRules;
 ///   Handles "streamrise" spam.
 /// </summary>
 public class StreamRise : AChatRule {
-  private const string _spam = "Hello, sorry for bothering you. I want to offer promotion of your channel, " +
+  private const string SPAM = "Hello, sorry for bothering you. I want to offer promotion of your channel, " +
                                "viewers, followers, views, chat bots, etc...The price is lower than any competitor, " +
                                "the quality is guaranteed to be the best.   Flexible and convenient order management " +
                                "panel, chat panel, everything is in your hands, a huge number of custom settings. Go " +
@@ -24,7 +24,7 @@ public override bool ShouldRun(TwitchUserConfig config) {
   /// <inheritdoc />
   public override async Task<bool> Handle(string channelId, ITwitchApiProxy botProxy, TwitchChatMessage message,
     INullinsideContext db, CancellationToken stoppingToken = new()) {
-    if (message.IsFirstMessage && _spam.Equals(message.Message, StringComparison.InvariantCultureIgnoreCase)) {
+    if (message.IsFirstMessage && SPAM.Equals(message.Message, StringComparison.InvariantCultureIgnoreCase)) {
       await BanAndLog(channelId, botProxy, new[] { (message.UserId, message.Username) },
         "[Bot] Spam (StreamRise)", db, stoppingToken);
       return false;

src/Nullinside.Api.TwitchBot/ChatRules/StreamViewers.cs

@@ -10,9 +10,9 @@ namespace Nullinside.Api.TwitchBot.ChatRules;
 ///   Handles "streamviewers org" spam.
 /// </summary>
 public class StreamViewers : AChatRule {
-  private const int MinThreshold = 70;
+  private const int MIN_THRESHOLD = 70;
 
-  private const string ExpectedSpamMessage =
+  private const string EXPECTED_SPAM_MESSAGE =
     "doyoualreadytriedstreamviewersorg?realviewers,fireworks!theyarenowgivingoutafreepackageforstreamersoo";
 
   /// <inheritdoc />
@@ -47,13 +47,13 @@ public override async Task<bool> Handle(string channelId, ITwitchApiProxy botPro
 
     // With no spaces the message will be exactly the length of our spam message.
     string noSpaces = string.Concat(parts);
-    if (noSpaces.Length != ExpectedSpamMessage.Length) {
+    if (noSpaces.Length != EXPECTED_SPAM_MESSAGE.Length) {
       return true;
     }
 
     // Determine how similar the message is to the spam message.
     int matches = 0;
-    for (int i = 0; i < ExpectedSpamMessage.Length; i++) {
+    for (int i = 0; i < EXPECTED_SPAM_MESSAGE.Length; i++) {
       // If it's not an ascii character it might mean they're trying to obfuscate by swapping out letters that look
       // like ascii characters. Like an e with an accent mark instead of an ascii e. They'll look almost the same to
       // the reader but the character will be different. We can skip these and assume it doesn't count as a match.
@@ -65,7 +65,7 @@ public override async Task<bool> Handle(string channelId, ITwitchApiProxy botPro
       // strings must match. There shouldn't be any letters in order that we aren't expecting provided they're actually
       // ascii characters. If, for some reason, there is a letter in this position that we aren't expecting it means it
       // is not our spam message.
-      if (noSpaces[i] != ExpectedSpamMessage[i]) {
+      if (noSpaces[i] != EXPECTED_SPAM_MESSAGE[i]) {
         return true;
       }
 
@@ -74,7 +74,7 @@ public override async Task<bool> Handle(string channelId, ITwitchApiProxy botPro
     }
 
     // If we had less character matches than our threshold then this wasn't a spam message.
-    if (matches < MinThreshold) {
+    if (matches < MIN_THRESHOLD) {
       return true;
     }
 

src/Nullinside.Api.TwitchBot/Constants.cs

@@ -7,23 +7,23 @@ public static class Constants {
   /// <summary>
   ///   The email address associated with the twitch account for the bot.
   /// </summary>
-  public const string BotEmail = "[email protected]";
+  public const string BOT_EMAIL = "[email protected]";
 
   /// <summary>
   ///   The twitch username for the bot account.
   /// </summary>
-  public const string BotUsername = "nullinside";
+  public const string BOT_USERNAME = "nullinside";
 
   /// <summary>
   ///   The twitch id for the bot account.
   /// </summary>
-  public const string BotId = "640082552";
+  public const string BOT_ID = "640082552";
 
   // TODO: This should be dynamic but I need to find a source of "good bots" lists. Might have to cheap out and just do a database table with data entry. Let users of the bot submit suggestions that we approve manually.
   /// <summary>
   ///   The whitelist of bots to not ban.
   /// </summary>
-  public static readonly string[] WhitelistedBots = {
+  public static readonly string[] WHITELISTED_BOTS = {
     "soundalerts", "nightbot", "streamlabs",
     "pokemoncommunitygame", "streamelements",
     "moobot", "wizebot", "bad_elbereth", "dixperbro",
@@ -37,10 +37,10 @@ public static class Constants {
   /// <summary>
   ///   The minimum time that must elapse between user's getting scanned.
   /// </summary>
-  public static readonly TimeSpan MinimumTimeBetweenScans = TimeSpan.FromSeconds(30);
+  public static readonly TimeSpan MINIMUM_TIME_BETWEEN_SCANS = TimeSpan.FromSeconds(30);
 
   /// <summary>
   ///   The minimum time that must elapse between user's getting scanned if they are currently live.
   /// </summary>
-  public static readonly TimeSpan MinimumTimeBetweenScansLive = TimeSpan.FromSeconds(1);
+  public static readonly TimeSpan MINIMUM_TIME_BETWEEN_SCANS_LIVE = TimeSpan.FromSeconds(1);
 }

src/Nullinside.Api.TwitchBot/Controllers/BotController.cs

@@ -72,7 +72,7 @@ public BotController(INullinsideContext dbContext, IConfiguration configuration)
     IEnumerable<Moderator> mods = await api.GetChannelMods(user.TwitchId, token);
     return Ok(new {
       isMod = null != mods.FirstOrDefault(m =>
-        string.Equals(m.UserId, Constants.BotId, StringComparison.InvariantCultureIgnoreCase))
+        string.Equals(m.UserId, Constants.BOT_ID, StringComparison.InvariantCultureIgnoreCase))
     });
   }
 
@@ -97,7 +97,7 @@ public async Task<IActionResult> ModBotAccount([FromServices] ITwitchApiProxy ap
     }
 
     api.Configure(user);
-    bool success = await api.AddChannelMod(user.TwitchId, Constants.BotId, token);
+    bool success = await api.AddChannelMod(user.TwitchId, Constants.BOT_ID, token);
     return Ok(success);
   }