Merge pull request #23 from nullinside-development-group/chore/update

chore: syncing conventions

Author: ProgrammingByPermutation

src/Nullinside.Cicd.GitHub/.editorconfig

@@ -29,7 +29,6 @@ end_of_line = lf
 insert_final_newline = false
 
 #### .NET Coding Conventions ####
-[*.{cs,vb}]
 
 # Organize usings
 dotnet_separate_import_directive_groups = true
@@ -82,7 +81,6 @@ dotnet_code_quality_unused_parameters = all:suggestion
 dotnet_remove_unnecessary_suppression_exclusions = none
 
 #### C# Coding Conventions ####
-[*.cs]
 
 # var preferences
 csharp_style_var_elsewhere = false:silent
@@ -179,7 +177,6 @@ csharp_preserve_single_line_blocks = true
 csharp_preserve_single_line_statements = true
 
 #### Naming styles ####
-[*.{cs,vb}]
 
 # Naming rules
 
@@ -233,19 +230,19 @@ dotnet_naming_rule.private_static_fields_should_be_s_camelcase.style = s_camelca
 
 dotnet_naming_rule.public_constant_fields_should_be_pascalcase.severity = suggestion
 dotnet_naming_rule.public_constant_fields_should_be_pascalcase.symbols = public_constant_fields
-dotnet_naming_rule.public_constant_fields_should_be_pascalcase.style = pascalcase
+dotnet_naming_rule.public_constant_fields_should_be_pascalcase.style = all_upper
 
 dotnet_naming_rule.private_constant_fields_should_be_pascalcase.severity = suggestion
 dotnet_naming_rule.private_constant_fields_should_be_pascalcase.symbols = private_constant_fields
-dotnet_naming_rule.private_constant_fields_should_be_pascalcase.style = pascalcase
+dotnet_naming_rule.private_constant_fields_should_be_pascalcase.style = all_upper
 
 dotnet_naming_rule.public_static_readonly_fields_should_be_pascalcase.severity = suggestion
 dotnet_naming_rule.public_static_readonly_fields_should_be_pascalcase.symbols = public_static_readonly_fields
-dotnet_naming_rule.public_static_readonly_fields_should_be_pascalcase.style = pascalcase
+dotnet_naming_rule.public_static_readonly_fields_should_be_pascalcase.style = all_upper
 
 dotnet_naming_rule.private_static_readonly_fields_should_be_pascalcase.severity = suggestion
 dotnet_naming_rule.private_static_readonly_fields_should_be_pascalcase.symbols = private_static_readonly_fields
-dotnet_naming_rule.private_static_readonly_fields_should_be_pascalcase.style = pascalcase
+dotnet_naming_rule.private_static_readonly_fields_should_be_pascalcase.style = all_upper
 
 dotnet_naming_rule.enums_should_be_pascalcase.severity = suggestion
 dotnet_naming_rule.enums_should_be_pascalcase.symbols = enums
@@ -369,3 +366,7 @@ dotnet_naming_style.s_camelcase.required_suffix =
 dotnet_naming_style.s_camelcase.word_separator =
 dotnet_naming_style.s_camelcase.capitalization = camel_case
 
+dotnet_naming_style.all_upper.required_prefix =
+dotnet_naming_style.all_upper.required_suffix =
+dotnet_naming_style.all_upper.word_separator = _
+dotnet_naming_style.all_upper.capitalization = all_upper

src/Nullinside.Cicd.GitHub/Constants.cs

@@ -23,9 +23,9 @@ public static class Constants {
   ///   The github project's unique identifier on github.
   /// </summary>
   public const int GITHUB_PROJECT_NUM = 1;
-  
+
   /// <summary>
-  /// The unique identifier on GitHub for the "done" status of items.
+  ///   The unique identifier on GitHub for the "done" status of items.
   /// </summary>
   /// <remarks>This was found by manually querying the API. It's a nightmare to pull. Hence the hardcoding.</remarks>
   public const string GITHUB_PROJECT_DONE_SINGLE_SELECT_ID = "98236657";

src/Nullinside.Cicd.GitHub/Nullinside.Cicd.GitHub.csproj

@@ -19,7 +19,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="log4net" Version="3.1.0" />
+        <PackageReference Include="log4net" Version="3.1.0"/>
         <PackageReference Include="log4net.Ext.Json" Version="3.0.3"/>
         <PackageReference Include="Octokit" Version="14.0.0"/>
     </ItemGroup>

src/global.json

@@ -0,0 +1,6 @@
+{
+  "sdk": {
+    "rollForward": "latestMajor",
+    "allowPrerelease": false
+  }
+}