Merge pull request #18 from nullinside-development-group/chore/updates

chore: update log message and save magic number in constants file

Author: ProgrammingByPermutation

src/Nullinside.Cicd.GitHub/Constants.cs

@@ -23,4 +23,10 @@ public static class Constants {
   ///   The github project's unique identifier on github.
   /// </summary>
   public const int GITHUB_PROJECT_NUM = 1;
+  
+  /// <summary>
+  /// The unique identifier on GitHub for the "done" status of items.
+  /// </summary>
+  /// <remarks>This was found by manually querying the API. It's a nightmare to pull. Hence the hardcoding.</remarks>
+  public const string GITHUB_PROJECT_DONE_SINGLE_SELECT_ID = "98236657";
 }

src/Nullinside.Cicd.GitHub/Rule/MoveClosedToDone.cs

@@ -38,9 +38,9 @@ from projects in issueInfo.ProjectItems.Nodes
         continue;
       }
 
-      _log.Info($"{repo.Name}: Associating issue #{issue.IssueNumber}");
+      _log.Info($"{repo.Name}: Moving issue to done column (issue #{issue.IssueNumber})");
 
-      var mutation = new MutateIssueProjectStatuses(projectId.Value, issue.ProjectIssueId, issue.FieldId, "98236657");
+      var mutation = new MutateIssueProjectStatuses(projectId.Value, issue.ProjectIssueId, issue.FieldId, Constants.GITHUB_PROJECT_DONE_SINGLE_SELECT_ID);
       await mutation.SendAsync();
     }
   }