Skip to content

feat: adding loading icons to login #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ProgrammingByPermutation merged 1 commit into from
Jul 23, 2025
Merged

feat: adding loading icons to login #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/TwitchStreamingTools/ViewModels/Pages/AccountViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,21 @@ public class AccountViewModel : PageViewModelBase, IDisposable {
/// </summary>
private readonly ITwitchAccountService _twitchAccountService;

/// <summary>
/// True if currently downloading the logged in user's profile photo, false otherwise.
/// </summary>
private bool _downloadingProfileImage;

/// <summary>
/// True if we have a valid OAuth token, false otherwise.
/// </summary>
private bool _hasValidOAuthToken;

/// <summary>
/// True if currently in the logging in process, false otherwise.
/// </summary>
private bool _loggingIn;

/// <summary>
/// The profile image of the logged in user.
/// </summary>
Expand Down Expand Up @@ -110,6 +120,22 @@ public Bitmap? ProfileImage {
/// </summary>
public ReactiveCommand<Unit, Unit> OnLogout { get; }

/// <summary>
/// True if currently in the logging in process, false otherwise.
/// </summary>
public bool LoggingIn {
get => _loggingIn;
set => this.RaiseAndSetIfChanged(ref _loggingIn, value);
}

/// <summary>
/// True if currently downloading the logged in user's profile photo, false otherwise.
/// </summary>
public bool DownloadingProfileImage {
get => _downloadingProfileImage;
set => this.RaiseAndSetIfChanged(ref _downloadingProfileImage, value);
}

/// <summary>
/// True if we have a valid OAuth token, false otherwise.
/// </summary>
Expand Down Expand Up @@ -157,18 +183,21 @@ public override async void OnLoaded() {
private async Task LoadProfileImage() {
// Try to get the file locally.
string? profileImagePath = string.Format(PROFILE_IMAGE_FILENAME, _configuration.TwitchUsername);
profileImagePath = Path.Combine(PROFILE_IMAGE_FOLDER, profileImagePath);
if (File.Exists(profileImagePath)) {
ProfileImage = new Bitmap(profileImagePath);
return;
}

// If we couldn't find the file, download it.
DownloadingProfileImage = true;
profileImagePath = await DownloadUserImage().ConfigureAwait(false);
if (null == profileImagePath) {
return;
}

ProfileImage = new Bitmap(profileImagePath);
DownloadingProfileImage = false;
}

/// <summary>
Expand Down Expand Up @@ -213,6 +242,7 @@ private void OnCredentialsStatusChanged(bool valid) {
/// Launches the computer's default browser to generate an OAuth token.
/// </summary>
private async void PerformLogin() {
LoggingIn = true;
try {
CancellationToken token = CancellationToken.None;

Expand Down Expand Up @@ -252,6 +282,9 @@ private async void PerformLogin() {
catch (Exception ex) {
_logger.Error("Failed to launch browser to login", ex);
}
finally {
LoggingIn = false;
}
}

/// <summary>
Expand Down
10 changes: 7 additions & 3 deletions src/TwitchStreamingTools/Views/Pages/AccountView.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:pages="clr-namespace:TwitchStreamingTools.ViewModels.Pages"
xmlns:controls="clr-namespace:TwitchStreamingTools.Controls"
mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
x:Class="TwitchStreamingTools.Views.Pages.AccountView"
x:DataType="pages:AccountViewModel">
Expand All @@ -24,16 +25,19 @@
DockPanel.Dock="Top"
Spacing="15">
<Image Width="200" Source="/Assets/twitch-wordart.png" />
<controls:Loading IsVisible="{Binding !LoggingIn}" Width="50" Height="50" />
<Button IsVisible="{Binding !HasValidOAuthToken}"
IsEnabled="{Binding !LoggingIn}"
Command="{Binding OnPerformLogin}"
HorizontalAlignment="Center"
VerticalContentAlignment="Top">
Login
</Button>
<Border CornerRadius="75" Width="150" ClipToBounds="True">
<Image Source="{Binding ProfileImage}" />
</Border>
<StackPanel IsVisible="{Binding HasValidOAuthToken}" Spacing="5">
<controls:Loading IsVisible="{Binding DownloadingProfileImage}" />
<Border CornerRadius="75" Width="150" ClipToBounds="True" IsVisible="{Binding !DownloadingProfileImage}">
<Image Source="{Binding ProfileImage}" />
</Border>
<Grid>
<Grid.ColumnDefinitions>
<ColumnDefinition Width="Auto" />
Expand Down