From 1e03af219aaf0a329113a5ef5221cca74576c10d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88?=
 <dev.nullinside@gmail.com>
Date: Fri, 4 Oct 2024 14:29:50 -0400
Subject: [PATCH] Removing "MarginHack" from LoadingIcon

Set up all the loading icons so their text and gif were aligned. Removed
the hack property to offset them on every screen.

closes #25
---
 .../components/loading-icon/loading-icon.component.html       | 2 +-
 .../common/components/loading-icon/loading-icon.component.ts  | 1 -
 src/src/app/view/login-landing/login-landing.component.html   | 2 +-
 src/src/app/view/login/login.component.html                   | 2 +-
 src/src/app/view/vm-manager/vm-manager.component.html         | 4 ++--
 5 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/src/app/common/components/loading-icon/loading-icon.component.html b/src/src/app/common/components/loading-icon/loading-icon.component.html
index b1416be..55c3db7 100644
--- a/src/src/app/common/components/loading-icon/loading-icon.component.html
+++ b/src/src/app/common/components/loading-icon/loading-icon.component.html
@@ -21,6 +21,6 @@
       repeatCount="indefinite" />
   </path>
 </svg>
-<div class="text-area" [style.font-size]="fontSize" [style.margin-top]="marginHack">
+<div class="text-area" [style.font-size]="fontSize">
   <ng-content></ng-content>
 </div>
diff --git a/src/src/app/common/components/loading-icon/loading-icon.component.ts b/src/src/app/common/components/loading-icon/loading-icon.component.ts
index d849e8d..ca072e4 100644
--- a/src/src/app/common/components/loading-icon/loading-icon.component.ts
+++ b/src/src/app/common/components/loading-icon/loading-icon.component.ts
@@ -8,7 +8,6 @@ import { Component, Input } from '@angular/core';
   styleUrl: './loading-icon.component.scss'
 })
 export class LoadingIconComponent {
-  @Input() marginHack = '0px';
   @Input() width = '100%';
   @Input() height = '100%';
   @Input() fontSize = '14px';
diff --git a/src/src/app/view/login-landing/login-landing.component.html b/src/src/app/view/login-landing/login-landing.component.html
index 285161b..416c2ed 100644
--- a/src/src/app/view/login-landing/login-landing.component.html
+++ b/src/src/app/view/login-landing/login-landing.component.html
@@ -4,7 +4,7 @@
   </div>
   <div class="centered-box_content-container">
     @if (error === '') {
-      <app-loading-icon fontSize="24px" height="35px" width="35px" marginHack="-25px">Logging in</app-loading-icon>
+      <app-loading-icon fontSize="24px" height="35px" width="35px">Logging in</app-loading-icon>
     } @else {
       <div class="error-banner">{{ error }}</div>
     }
diff --git a/src/src/app/view/login/login.component.html b/src/src/app/view/login/login.component.html
index fd1f10c..eb30034 100644
--- a/src/src/app/view/login/login.component.html
+++ b/src/src/app/view/login/login.component.html
@@ -19,7 +19,7 @@
     <app-twitch-login [twitchScopeIndex]="0" />
   </div>
   <div class="centered-box_content-container" [hidden]="!checkingLogin">
-    <app-loading-icon fontSize="24px" height="35px" width="35px" marginHack="-25px">
+    <app-loading-icon fontSize="24px" height="35px" width="35px">
       Checking Login Info
     </app-loading-icon>
   </div>
diff --git a/src/src/app/view/vm-manager/vm-manager.component.html b/src/src/app/view/vm-manager/vm-manager.component.html
index f0fdcb1..8e1e8c8 100644
--- a/src/src/app/view/vm-manager/vm-manager.component.html
+++ b/src/src/app/view/vm-manager/vm-manager.component.html
@@ -31,7 +31,7 @@ <h1>
                       [fontIcon]="vm.isOnline ? 'power_off' : 'power_settings_new'"
                       [matTooltip]="vm.isOnline ? 'Turn Off' : 'Turn On'" />
           } @else {
-            <app-loading-icon fontSize="24px" height="35px" width="35px" marginHack="-25px" />
+            <app-loading-icon fontSize="24px" height="35px" width="35px" />
           }
         </h1>
         <p>{{ vm.notes }}</p>
@@ -46,6 +46,6 @@ <h1>
   </div>
 } @else if (!error) {
   <div class="layout-content" style="text-align: center">
-    <app-loading-icon fontSize="24px" height="35px" width="35px" marginHack="-25px">Getting VMs...</app-loading-icon>
+    <app-loading-icon fontSize="24px" height="35px" width="35px">Getting VMs...</app-loading-icon>
   </div>
 }