Merge pull request #91 from Fullscreen/rescue-invalid-uri

Rescue invalid URI when fetching a page

Author: claudiofullscreen

CHANGELOG.md

@@ -6,6 +6,10 @@ For more information about changelogs, check
 [Keep a Changelog](http://keepachangelog.com) and
 [Vandamme](http://tech-angels.github.io/vandamme).
 
+## 0.2.26 - 2017/06/06
+
+* [ENHANCEMENT] Raise ContentNotFound if Page#find is called with an invalid URI
+
 ## 0.2.25 - 2017/05/16
 
 * [FEATURE] Retry up to 5 times if Facebook responds with error

lib/funky/connections/api.rb

@@ -26,6 +26,8 @@ def self.fetch_data_with_paging_token(uri)
       def self.fetch(path_query, is_array: false)
         uri = URI "https://#{host}/v2.8/#{path_query}&limit=100&access_token=#{app_id}%7C#{app_secret}"
         is_array ? fetch_multiple_pages(uri).uniq : json_for(uri)
+      rescue URI::InvalidURIError
+        raise Funky::ContentNotFound, "Invalid URL"
       end
 
       def self.fetch_multiple_pages(uri)

lib/funky/version.rb

@@ -1,3 +1,3 @@
 module Funky
-  VERSION = "0.2.25"
+  VERSION = "0.2.26"
 end

spec/pages/find_spec.rb

@@ -25,6 +25,12 @@
       it { expect { page }.to raise_error(Funky::ContentNotFound) }
     end
 
+    context 'given an invalid URI was passed' do
+      let(:page_id) { ' some invalid URL ' }
+
+      it { expect { page }.to raise_error(Funky::ContentNotFound) }
+    end
+
     context 'given a website url was passed' do
       let(:page_id) { website_url }
 

spec/pages/videos_spec.rb

@@ -38,7 +38,7 @@
       let(:page_id) { nextflix_page_id }
 
       # NOTE: This test fails if we only strictly followed the Facebook
-      # documentation of fetching pages with timestmap-based pagination.
+      # documentation of fetching pages with timestamp-based pagination.
       specify 'includes the oldest video of the page' do
         expect(videos.map {|v| v.id}).to include '68196585394'
       end
@@ -48,7 +48,7 @@
       let(:page_id) { nbc_page_id }
 
       # NOTE: This test fails if we only strictly followed the Facebook
-      # documentation of fetching pages with timestmap-based pagination.
+      # documentation of fetching pages with timestamp-based pagination.
       specify 'includes the oldest video of the page' do
         expect(videos.map {|v| v.id}).to include '10152197716420746'
       end