breaking: rename alias default to active (#89)

Author: numToStr

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [0.8.0]
 
+### Breaking
+
+-   Rename active version alias from `default` to `active` [#89](https://github.com/numToStr/snm/pull/89)
+
+> If you are upgrading from an older version, `snm` will not recognize the running version. To fix this just run the `use` command with a version of your choice.
+
 ### Changes
 
 -   Rename `prune` command to `purge` but retain `prune` as an alias [#82](https://github.com/numToStr/snm/pull/82)

src/cli/config.rs

@@ -72,9 +72,7 @@ impl Config {
     }
 
     pub fn alias_default(&self) -> AliasDir {
-        let p = self.alias_dir().as_ref().join(UserAlias::DEFAULT);
-
-        AliasDir::new(p)
+        self.alias_dir().join(UserAlias::ACTIVE)
     }
 
     pub fn bin_path(&self, path: &Path) -> PathBuf {

src/commands/ls.rs

@@ -17,7 +17,7 @@ impl super::Command for Ls {
         for version in versions.into_iter() {
             match aliases.get(&version) {
                 Some(a) => {
-                    if a.contains(&UserAlias::DEFAULT.to_string()) {
+                    if a.iter().any(|x| *x == UserAlias::ACTIVE) {
                         println!("> {} \t{}", style(version).bold(), a.join(", "));
                     } else {
                         println!("- {} \t{}", version, a.join(", "));

src/commands/purge.rs

@@ -31,13 +31,13 @@ impl super::Command for Purge {
         if !default_alias.as_ref().exists() {
             anyhow::bail!(
                 "Unable to prune. No {} alias found",
-                style(UserAlias::DEFAULT).bold()
+                style(UserAlias::ACTIVE).bold()
             );
         }
 
         let release_dir = config.release_dir();
 
-        let used_ver = Linker::read_convert_to_dist(&default_alias, &release_dir)?;
+        let active_ver = Linker::read_convert_to_dist(&default_alias, &release_dir)?;
 
         // Nuke the alias directory after reading the default alias
         remove_dir_all(config.alias_dir().as_ref())?;
@@ -49,7 +49,7 @@ impl super::Command for Purge {
         let dist_versions = DistVersion::list_versions(&release_dir)?;
         for version in dist_versions {
             // If the version is currently active then don't delete
-            if version.eq(&used_ver) {
+            if version.eq(&active_ver) {
                 continue;
             }
 
@@ -63,7 +63,7 @@ impl super::Command for Purge {
         // Restoring the default alias
         // NOTE: don't use the `default_alias` variable
         Linker::create_link(
-            &release_dir.join(used_ver.to_string()),
+            &release_dir.join(active_ver.to_string()),
             &config.alias_default(),
         )?;
 

src/commands/uninstall.rs

@@ -11,11 +11,11 @@ use snm_core::{
 #[derive(Debug, Clap)]
 pub struct UnInstall {
     /// Semver, Alias or Lts codename that needs to be removed
-    version_or_alias: UserVersion,
+    version: UserVersion,
 
-    /// Don't remove if the version is currently used.
+    /// Don't remove if the version is currently active.
     #[clap(short = 'N', long)]
-    no_used: bool,
+    no_active: bool,
 }
 
 impl super::Command for UnInstall {
@@ -25,15 +25,15 @@ impl super::Command for UnInstall {
 
         // first we need to find out the whether the provided version is an alias, lts codename or partial semver
         // If the version is alias or codename, then we need to find the linked/installed version
-        let version = match &self.version_or_alias {
+        let version = match &self.version {
             UserVersion::Lts(lts_code) => {
                 let alias_ver = alias_dir.join(&lts_code.to_string());
 
                 if !alias_ver.as_ref().exists() {
                     anyhow::bail!("Codename {} not found", style(lts_code).bold());
                 }
 
-                Linker::read_convert_to_dist(&alias_dir, &release_dir)?
+                Linker::read_convert_to_dist(&alias_ver, &release_dir)?
             }
             UserVersion::Alias(alias) => {
                 let alias_ver = alias_dir.join(alias.as_ref());
@@ -42,7 +42,7 @@ impl super::Command for UnInstall {
                     anyhow::bail!("Alias {} not found", style(alias).bold());
                 }
 
-                Linker::read_convert_to_dist(&alias_dir, &release_dir)?
+                Linker::read_convert_to_dist(&alias_ver, &release_dir)?
             }
             x => DistVersion::match_version(&release_dir, x)?,
         };
@@ -51,12 +51,12 @@ impl super::Command for UnInstall {
         // then remove them all the aliases before removing the actuall installed version
         let aliases = Linker::list_for_version(&version, &alias_dir, &release_dir)?;
 
-        // Checking whether the version is currently used or not
-        let is_default = aliases.iter().any(|x| x.as_str() == UserAlias::DEFAULT);
+        // Checking whether the version is currently active or not
+        let is_default = aliases.iter().any(|x| *x == UserAlias::ACTIVE);
 
-        if is_default && self.no_used {
+        if is_default && self.no_active {
             anyhow::bail!(
-                "Unable to uninstall. Version {} is currently used!",
+                "Unable to uninstall. Version {} is currently active!",
                 style(version).bold()
             );
         }

src/lib/types.rs

@@ -4,6 +4,8 @@ use std::{
     str::FromStr,
 };
 
+use console::style;
+
 macro_rules! as_ref {
     ($impl: ident, $ty: ty) => {
         impl AsRef<$ty> for $impl {
@@ -54,7 +56,7 @@ as_ref!(UserLts, str);
 pub struct UserAlias(String);
 
 impl UserAlias {
-    pub const DEFAULT: &'static str = "default";
+    pub const ACTIVE: &'static str = "active";
 
     pub fn new(s: &str) -> Self {
         Self(s.replace('/', "-").replace('\\', "-"))
@@ -72,6 +74,10 @@ impl Display for UserAlias {
 impl FromStr for UserAlias {
     type Err = anyhow::Error;
     fn from_str(s: &str) -> Result<Self, Self::Err> {
+        if s == Self::ACTIVE {
+            anyhow::bail!("{} is not allowed", style(Self::ACTIVE).bold())
+        }
+
         Ok(Self::new(s))
     }
 }

src/lib/version/user_version.rs

@@ -54,7 +54,8 @@ impl ParseVersion for UserVersion {
             } else if UserLts::is_lts(v) {
                 Self::Lts(UserLts::new(v))
             } else {
-                Self::Alias(UserAlias::new(v))
+                // from_str method is used bcz it returns err if the given alias is same as active alias
+                Self::Alias(UserAlias::from_str(v)?)
             }
         };