Merge pull request #51 from Shobbak/fix/crash-divided-by-zero

fix: measuredBitRate divided by zero crash. fixed #49

Author: numandev1

.github/FUNDING.yml

@@ -0,0 +1,12 @@
+# These are supported funding model platforms
+
+github: nomi9995 # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
+patreon: # Replace with a single Patreon username
+open_collective: # Replace with a single Open Collective username
+ko_fi: # Replace with a single Ko-fi username
+tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
+community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
+liberapay: # Replace with a single Liberapay username
+issuehunt: # Replace with a single IssueHunt username
+otechie: # Replace with a single Otechie username
+custom: http://buymeacoffee.com/numan.dev # Replace with a single custom sponsorship URL

README.md

@@ -1,3 +1,9 @@
+### Would you like to support me?
+
+<a href="https://www.buymeacoffee.com/numan.dev" target="_blank"><img src="https://www.buymeacoffee.com/assets/img/custom_images/orange_img.png" alt="Buy Me A Coffee" style="height: auto !important;width: auto !important;" ></a>
+
+---
+
 # react-native-compressor
 
 <!-- Title -->

example/ios/Podfile.lock

@@ -293,7 +293,7 @@ PODS:
     - glog
   - react-native-background-upload (6.5.0):
     - React
-  - react-native-compressor (1.0.3):
+  - react-native-compressor (1.1.0):
     - NextLevelSessionExporter
     - React-Core
   - react-native-create-thumbnail (1.4.1):
@@ -627,7 +627,7 @@ SPEC CHECKSUMS:
   React-jsinspector: 8c0517dee5e8c70cd6c3066f20213ff7ce54f176
   React-logger: bfddd3418dc1d45b77b822958f3e31422e2c179b
   react-native-background-upload: 994d4e8abbcc1d0b0cff68d950429906ed68ca67
-  react-native-compressor: fd8cc4b27fcd00e5e784b4d8d00583075326811f
+  react-native-compressor: 2b0f75c5e887830955b32e0ddf22ef2efe0f179e
   react-native-create-thumbnail: d31c84dd69fb4d60aec0ff2f49bc0de41ede7b2c
   react-native-document-picker: 226068006be4c52f8ef7f32d855ee025a12e9e64
   react-native-get-random-values: 2c4ff6b44cb71291dabe9a8ae87d3877dcf387da

example/src/Screens/Video/index.tsx

@@ -114,7 +114,7 @@ export default function App() {
       sourceVideo,
       {
         compressionMethod: 'auto',
-        minimumFileSizeForCompress: 16,
+        minimumFileSizeForCompress: 2,
       },
       (progress) => {
         if (backgroundMode) {

ios/Video/VideoCompressor.swift

@@ -245,8 +245,8 @@ func makeValidUri(filePath: String) -> String {
         let compressFactor:Float = 0.8
         let  minCompressFactor:Float = 0.8
         let maxBitrate:Int = 1669000
-
-        var remeasuredBitrate:Int = originalBitrate / (min(originalHeight/height,originalWidth/width))
+        let minValue:Float=min(Float(originalHeight)/Float(height),Float(originalWidth)/Float(width))
+        var remeasuredBitrate:Int = Int(Float(originalBitrate) / minValue)
         remeasuredBitrate = remeasuredBitrate*Int(compressFactor)
         let minBitrate:Int = self.getVideoBitrateWithFactor(f: minCompressFactor) / (1280 * 720 / (width * height))
         if (originalBitrate < minBitrate) {