Skip to content

Commit 0cdf467

Browse files
authored
fix: cron parser uses 6 field format (#3068)
Signed-off-by: Vigith Maurice <[email protected]>
1 parent 74885f5 commit 0cdf467

File tree

10 files changed

+15
-15
lines changed

10 files changed

+15
-15
lines changed

docs/specifications/side-inputs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ spec:
111111
container:
112112
image: my-sideinputs-image:v1
113113
trigger:
114-
schedule: "*/15 * * * *"
114+
schedule: "0 */15 * * * *"
115115
# interval: 180s
116116
# timezone: America/Los_Angeles
117117
vertices:

docs/user-guide/reference/side-inputs.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ spec:
2222
container:
2323
image: my-sideinputs-s3-image:v1
2424
trigger:
25-
schedule: "*/15 * * * *"
25+
schedule: "0 */15 * * * *"
2626
# timezone: America/Los_Angeles
2727
- name: redis
2828
container:
2929
image: my-sideinputs-redis-image:v1
3030
trigger:
31-
schedule: "*/15 * * * *"
31+
schedule: "0 */15 * * * *"
3232
# timezone: America/Los_Angeles
3333
vertices:
3434
- name: my-vertex

pkg/reconciler/pipeline/controller_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,7 @@ func Test_createOrUpdateSIMDeployments(t *testing.T) {
971971
Image: "test",
972972
},
973973
Trigger: &dfv1.SideInputTrigger{
974-
Schedule: "1 * * * *",
974+
Schedule: "0 1 * * * *",
975975
},
976976
},
977977
}
@@ -993,7 +993,7 @@ func Test_createOrUpdateSIMDeployments(t *testing.T) {
993993
Image: "test",
994994
},
995995
Trigger: &dfv1.SideInputTrigger{
996-
Schedule: "1 * * * *",
996+
Schedule: "0 1 * * * *",
997997
},
998998
},
999999
{
@@ -1002,7 +1002,7 @@ func Test_createOrUpdateSIMDeployments(t *testing.T) {
10021002
Image: "test",
10031003
},
10041004
Trigger: &dfv1.SideInputTrigger{
1005-
Schedule: "1 * * * *",
1005+
Schedule: "0 1 * * * *",
10061006
},
10071007
},
10081008
}
@@ -1025,7 +1025,7 @@ func Test_createOrUpdateSIMDeployments(t *testing.T) {
10251025
Image: "test",
10261026
},
10271027
Trigger: &dfv1.SideInputTrigger{
1028-
Schedule: "1 * * * *",
1028+
Schedule: "0 1 * * * *",
10291029
},
10301030
},
10311031
}

pkg/reconciler/vertex/controller_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -689,7 +689,7 @@ func Test_reconcile(t *testing.T) {
689689
Image: "test",
690690
},
691691
Trigger: &dfv1.SideInputTrigger{
692-
Schedule: "1 * * * *",
692+
Schedule: "0 1 * * * *",
693693
},
694694
},
695695
}

test/sideinputs-e2e/testdata/map-sideinput-pipeline.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ spec:
1010
image: quay.io/numaio/numaflow-go/map-sideinput:stable
1111
imagePullPolicy: IfNotPresent
1212
trigger:
13-
schedule: "*/5 * * * * *"
13+
schedule: "0 */5 * * * *"
1414
vertices:
1515
- name: in
1616
limits:

test/sideinputs-e2e/testdata/reduce-sideinput-pipeline.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ spec:
1313
image: quay.io/numaio/numaflow-go/reduce-sideinput:stable
1414
imagePullPolicy: IfNotPresent
1515
trigger:
16-
schedule: "*/5 * * * * *"
16+
schedule: "0 */5 * * * *"
1717
vertices:
1818
- name: in
1919
limits:

test/sideinputs-e2e/testdata/sideinput-sink.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ spec:
1010
image: quay.io/numaio/numaflow-go/sideinput-function:stable
1111
imagePullPolicy: IfNotPresent
1212
trigger:
13-
schedule: "*/5 * * * * *"
13+
schedule: "0 */5 * * * *"
1414
# timezone: America/Los_Angeles
1515
vertices:
1616
- name: in

test/sideinputs-e2e/testdata/sideinput-source.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ spec:
1010
image: quay.io/numaio/numaflow-go/sideinput-function:stable
1111
imagePullPolicy: IfNotPresent
1212
trigger:
13-
schedule: "*/5 * * * * *"
13+
schedule: "0 */5 * * * *"
1414
# timezone: America/Los_Angeles
1515
vertices:
1616
- name: in

ui/src/components/pages/Pipeline/partials/Graph/index.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ const mockData: GraphData = {
292292
imagePullPolicy: "Always",
293293
},
294294
trigger: {
295-
schedule: "*/2 * * * *",
295+
schedule: "0 */2 * * * *",
296296
timezone: null,
297297
},
298298
},
@@ -411,7 +411,7 @@ const mockData: GraphData = {
411411
imagePullPolicy: "Always",
412412
},
413413
trigger: {
414-
schedule: "*/2 * * * *",
414+
schedule: "0 */2 * * * *",
415415
timezone: null,
416416
},
417417
},

ui/src/components/pages/Pipeline/partials/Graph/partials/NodeInfo/index.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ describe("NodeInfo", () => {
7474
imagePullPolicy: "Always",
7575
},
7676
trigger: {
77-
schedule: "*/2 * * * *",
77+
schedule: "0 */2 * * * *",
7878
timezone: null,
7979
},
8080
},

0 commit comments

Comments
 (0)