Skip to content

Conversation

@BulkBeing
Copy link
Contributor

Explain what this PR does.

Closes #2254

@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (e8e9913) to head (20add6f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
- Coverage   70.51%   70.40%   -0.11%     
==========================================
  Files         395      395              
  Lines       61968    61968              
==========================================
- Hits        43696    43628      -68     
- Misses      17152    17222      +70     
+ Partials     1120     1118       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KeranYang
Copy link
Member

Please consider adding it to the builtin-source-e2e suite instead of creating a new one. Otherwise, you need to add it to the .github/workflows/ci.yaml

@BulkBeing
Copy link
Contributor Author

Please consider adding it to the builtin-source-e2e suite instead of creating a new one. Otherwise, you need to add it to the .github/workflows/ci.yaml

I've added it to ci.yaml instead of making it part of the builtin-source-e2e suite since we will be implementing the Pulsar sink in the future.

@BulkBeing
Copy link
Contributor Author

Snyk reports vulnerabilities with 2 indirect dependencies that got added when I added http://github.com/apache/pulsar-client-go (latest version).

I tried upgrading these indirect dependencies, but then all other tests started failing https://github.com/numaproj/numaflow/actions/runs/12193339406

    udsource_test.go:127: 
        	Error Trace:	/home/runner/work/numaflow/numaflow/test/udsource-e2e/udsource_test.go:127
        	            				/opt/hostedtoolcache/go/1.23.3/x64/src/runtime/asm_amd64.s:1700
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: credentials: cannot check peer: missing selected ALPN property"
        	Test:       	TestUserDefinedSourceSuite/TestUDSource
panic: runtime error: index out of range [0] with length 0

@BulkBeing BulkBeing marked this pull request as ready for review December 6, 2024 05:51
@vigith vigith marked this pull request as draft December 17, 2024 05:48
@vigith vigith marked this pull request as ready for review December 17, 2024 05:57
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BulkBeing please add the CI

@BulkBeing
Copy link
Contributor Author

The test is present in the CI pipeline (pulsar-e2e).

@BulkBeing BulkBeing marked this pull request as draft January 15, 2025 03:13
go.mod Outdated
github.com/gorilla/websocket v1.5.0 // indirect
github.com/hashicorp/errwrap v1.0.0 // indirect
github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c // indirect
github.com/hamba/avro/v2 v2.22.2-0.20240625062549-66aad10411d9 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can not be introduced, CVE-2023-37475, already been tagged by Intuit security.

@vigith vigith force-pushed the pulsar-e2e-tests branch from 430eede to 20add6f Compare April 29, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E tests for Builtin Pulsar Source

5 participants