Skip to content

Commit 43409dd

Browse files
authored
Merge pull request #1979 from numbersprotocol/feature-create-iframe-envvar
Feature create iframe envvar
2 parents 049401e + 67f42d9 commit 43409dd

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

set-secret.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const envConfigFile = `
88
export const BASE_URL = '${process.env.NUMBERS_STORAGE_BASE_URL}';
99
export const TRUSTED_CLIENT_KEY = '${process.env.NUMBERS_STORAGE_TRUSTED_CLIENT_KEY}';
1010
export const BUBBLE_DB_URL = '${process.env.NUMBERS_BUBBLE_DB_URL}';
11+
export const BUBBLE_IFRAME_URL = '${process.env.NUMBERS_BUBBLE_IFRAME_URL}';
1112
export const BUBBLE_API_URL = '${process.env.BUBBLE_API_URL}';
1213
export const APPS_FLYER_DEV_KEY = '${process.env.APPS_FLYER_DEV_KEY}'
1314
`;

src/app/features/home/details/details.page.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import { ConfirmAlert } from '../../../shared/confirm-alert/confirm-alert.servic
2929
import { ContactSelectionDialogComponent } from '../../../shared/contact-selection-dialog/contact-selection-dialog.component';
3030
import { DiaBackendAssetRepository } from '../../../shared/dia-backend/asset/dia-backend-asset-repository.service';
3131
import { DiaBackendAuthService } from '../../../shared/dia-backend/auth/dia-backend-auth.service';
32+
import { BUBBLE_IFRAME_URL } from '../../../shared/dia-backend/secret';
3233
import { DiaBackendWorkflowService } from '../../../shared/dia-backend/workflow/dia-backend-workflow.service';
3334
import { ErrorService } from '../../../shared/error/error.service';
3435
import { MediaStore } from '../../../shared/media/media-store/media-store.service';
@@ -183,11 +184,8 @@ export class DetailsPage {
183184
readonly iframeUrl$ = this.activeDetailedCapture$.pipe(
184185
distinctUntilChanged(),
185186
map(detailedCapture => {
186-
const host = 'https://captureappiframe.bubbleapps.io';
187-
const path = '';
188187
const params = `pid=${detailedCapture.id}&iframeLoadedFrom=CaptureApp`;
189-
// const params = `pid=288036ab-5768-4270-988b-a85d7bd11eb3&iframeLoadedFrom=CaptureApp`;
190-
const url = `${host}/${path}?${params}`;
188+
const url = `${BUBBLE_IFRAME_URL}/?${params}`;
191189
return this.sanitizer.bypassSecurityTrustResourceUrl(url);
192190
})
193191
);
@@ -209,10 +207,8 @@ export class DetailsPage {
209207
distinctUntilChanged(),
210208
map(([detailedCapture]) => {
211209
const token = this.userToken;
212-
const host = 'https://captureappiframe.bubbleapps.io';
213-
const path = 'version-qa-release/asset_page';
214210
const params = `pid=${detailedCapture.id}&token=${token}&iframeLoadedFrom=CaptureApp`;
215-
const url = `${host}/${path}?${params}`;
211+
const url = `${BUBBLE_IFRAME_URL}/asset_page?${params}`;
216212
return this.sanitizer.bypassSecurityTrustResourceUrl(url);
217213
})
218214
);
@@ -257,7 +253,7 @@ export class DetailsPage {
257253

258254
iframeUrlFor(detailedCapture: any) {
259255
return this.sanitizer.bypassSecurityTrustResourceUrl(
260-
`https://captureappiframe.bubbleapps.io/asset_page?pid=${detailedCapture.id}`
256+
`${BUBBLE_IFRAME_URL}/asset_page?pid=${detailedCapture.id}`
261257
);
262258
}
263259

src/app/features/home/explore-tab/explore-tab/explore-tab.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { Component } from '@angular/core';
22
import { DomSanitizer } from '@angular/platform-browser';
33
import { map } from 'rxjs/operators';
44
import { DiaBackendAuthService } from '../../../../shared/dia-backend/auth/dia-backend-auth.service';
5+
import { BUBBLE_IFRAME_URL } from '../../../../shared/dia-backend/secret';
56
import { ErrorService } from '../../../../shared/error/error.service';
67
import { NetworkService } from '../../../../shared/network/network.service';
78
import { isNonNullable } from '../../../../utils/rx-operators/rx-operators';
@@ -15,7 +16,7 @@ export class ExploreTabComponent {
1516
readonly bubbleIframeUrl$ = this.diaBackendAuthService.token$.pipe(
1617
isNonNullable(),
1718
map(token => {
18-
return `https://captureappiframe.numbersprotocol.io/version-qa-release/?token=${token}`;
19+
return `${BUBBLE_IFRAME_URL}/?token=${token}`;
1920
})
2021
);
2122

0 commit comments

Comments
 (0)