Skip to content

Commit 39950c6

Browse files
Colin Ian Kinggregkh
authored andcommitted
ALSA: seq: fix incorrect order of dest_client/dest_ports arguments
commit c3ea60c upstream. There are two occurrances of a call to snd_seq_oss_fill_addr where the dest_client and dest_port arguments are in the wrong order. Fix this by swapping them around. Addresses-Coverity: ("Arguments in wrong order") Signed-off-by: Colin Ian King <[email protected]> Cc: <[email protected]> Signed-off-by: Takashi Iwai <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent cd6f206 commit 39950c6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

sound/core/seq/oss/seq_oss_ioctl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ static int snd_seq_oss_oob_user(struct seq_oss_devinfo *dp, void __user *arg)
6262
if (copy_from_user(ev, arg, 8))
6363
return -EFAULT;
6464
memset(&tmpev, 0, sizeof(tmpev));
65-
snd_seq_oss_fill_addr(dp, &tmpev, dp->addr.port, dp->addr.client);
65+
snd_seq_oss_fill_addr(dp, &tmpev, dp->addr.client, dp->addr.port);
6666
tmpev.time.tick = 0;
6767
if (! snd_seq_oss_process_event(dp, (union evrec *)ev, &tmpev)) {
6868
snd_seq_oss_dispatch(dp, &tmpev, 0, 0);

sound/core/seq/oss/seq_oss_rw.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ insert_queue(struct seq_oss_devinfo *dp, union evrec *rec, struct file *opt)
174174
memset(&event, 0, sizeof(event));
175175
/* set dummy -- to be sure */
176176
event.type = SNDRV_SEQ_EVENT_NOTEOFF;
177-
snd_seq_oss_fill_addr(dp, &event, dp->addr.port, dp->addr.client);
177+
snd_seq_oss_fill_addr(dp, &event, dp->addr.client, dp->addr.port);
178178

179179
if (snd_seq_oss_process_event(dp, rec, &event))
180180
return 0; /* invalid event - no need to insert queue */

0 commit comments

Comments
 (0)