Skip to content

Commit 730855b

Browse files
jognessgregkh
authored andcommitted
fs/proc/array.c: allow reporting eip/esp for all coredumping threads
commit cb8f381 upstream. 0a1eb2d ("fs/proc: Stop reporting eip and esp in /proc/PID/stat") stopped reporting eip/esp and fd7d562 ("fs/proc: Report eip/esp in /prod/PID/stat for coredumping") reintroduced the feature to fix a regression with userspace core dump handlers (such as minicoredumper). Because PF_DUMPCORE is only set for the primary thread, this didn't fix the original problem for secondary threads. Allow reporting the eip/esp for all threads by checking for PF_EXITING as well. This is set for all the other threads when they are killed. coredump_wait() waits for all the tasks to become inactive before proceeding to invoke a core dumper. Link: http://lkml.kernel.org/r/[email protected] Link: http://lkml.kernel.org/r/[email protected] Fixes: fd7d562 ("fs/proc: Report eip/esp in /prod/PID/stat for coredumping") Signed-off-by: John Ogness <[email protected]> Reported-by: Jan Luebbe <[email protected]> Tested-by: Jan Luebbe <[email protected]> Cc: Alexey Dobriyan <[email protected]> Cc: Andy Lutomirski <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent e7d8130 commit 730855b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/proc/array.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
448448
* a program is not able to use ptrace(2) in that case. It is
449449
* safe because the task has stopped executing permanently.
450450
*/
451-
if (permitted && (task->flags & PF_DUMPCORE)) {
451+
if (permitted && (task->flags & (PF_EXITING|PF_DUMPCORE))) {
452452
if (try_get_task_stack(task)) {
453453
eip = KSTK_EIP(task);
454454
esp = KSTK_ESP(task);

0 commit comments

Comments
 (0)