Skip to content

Commit f0d331d

Browse files
tititiou36gregkh
authored andcommitted
net: moxa: Fix a potential double 'free_irq()'
[ Upstream commit ee8d226 ] Should an irq requested with 'devm_request_irq' be released explicitly, it should be done by 'devm_free_irq()', not 'free_irq()'. Fixes: 6c821bd ("net: Add MOXA ART SoCs ethernet driver") Signed-off-by: Christophe JAILLET <[email protected]> Signed-off-by: David S. Miller <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent bf3c068 commit f0d331d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/moxa/moxart_ether.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ static int moxart_remove(struct platform_device *pdev)
571571
struct net_device *ndev = platform_get_drvdata(pdev);
572572

573573
unregister_netdev(ndev);
574-
free_irq(ndev->irq, ndev);
574+
devm_free_irq(&pdev->dev, ndev->irq, ndev);
575575
moxart_mac_free_memory(ndev);
576576
free_netdev(ndev);
577577

0 commit comments

Comments
 (0)