Skip to content

Commit fb8c812

Browse files
asjgregkh
authored andcommitted
btrfs: use bool argument in free_root_pointers()
[ Upstream commit 4273eaf ] We don't need int argument bool shall do in free_root_pointers(). And rename the argument as it confused two people. Reviewed-by: Qu Wenruo <[email protected]> Signed-off-by: Anand Jain <[email protected]> Reviewed-by: David Sterba <[email protected]> Signed-off-by: David Sterba <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 131d3ff commit fb8c812

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

fs/btrfs/disk-io.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2104,7 +2104,7 @@ static void free_root_extent_buffers(struct btrfs_root *root)
21042104
}
21052105

21062106
/* helper to cleanup tree roots */
2107-
static void free_root_pointers(struct btrfs_fs_info *info, int chunk_root)
2107+
static void free_root_pointers(struct btrfs_fs_info *info, bool free_chunk_root)
21082108
{
21092109
free_root_extent_buffers(info->tree_root);
21102110

@@ -2113,7 +2113,7 @@ static void free_root_pointers(struct btrfs_fs_info *info, int chunk_root)
21132113
free_root_extent_buffers(info->csum_root);
21142114
free_root_extent_buffers(info->quota_root);
21152115
free_root_extent_buffers(info->uuid_root);
2116-
if (chunk_root)
2116+
if (free_chunk_root)
21172117
free_root_extent_buffers(info->chunk_root);
21182118
free_root_extent_buffers(info->free_space_root);
21192119
}
@@ -3136,7 +3136,7 @@ int open_ctree(struct super_block *sb,
31363136
btrfs_free_block_groups(fs_info);
31373137

31383138
fail_tree_roots:
3139-
free_root_pointers(fs_info, 1);
3139+
free_root_pointers(fs_info, true);
31403140
invalidate_inode_pages2(fs_info->btree_inode->i_mapping);
31413141

31423142
fail_sb_buffer:
@@ -3165,7 +3165,7 @@ int open_ctree(struct super_block *sb,
31653165
if (!btrfs_test_opt(tree_root->fs_info, USEBACKUPROOT))
31663166
goto fail_tree_roots;
31673167

3168-
free_root_pointers(fs_info, 0);
3168+
free_root_pointers(fs_info, false);
31693169

31703170
/* don't use the log in recovery mode, it won't be valid */
31713171
btrfs_set_super_log_root(disk_super, 0);
@@ -3862,7 +3862,7 @@ void close_ctree(struct btrfs_root *root)
38623862
btrfs_stop_all_workers(fs_info);
38633863

38643864
clear_bit(BTRFS_FS_OPEN, &fs_info->flags);
3865-
free_root_pointers(fs_info, 1);
3865+
free_root_pointers(fs_info, true);
38663866

38673867
iput(fs_info->btree_inode);
38683868

0 commit comments

Comments
 (0)