Skip to content

Commit ed46d0e

Browse files
committed
Added check for equality of Synapse object`s permanence values to their equals() method
1 parent 93cb8d2 commit ed46d0e

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/main/java/org/numenta/nupic/model/Synapse.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,8 @@ public boolean equals(Object obj) {
239239
return false;
240240
if(synapseIndex != other.synapseIndex)
241241
return false;
242+
if(permanence != other.permanence)
243+
return false;
242244
return true;
243245
}
244246
}

src/test/java/org/numenta/nupic/model/SynapseTest.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,18 @@ public void testSynapseEquality() {
5252
synapse1.setPresynapticCell(cell2);
5353
assertFalse(synapse1.equals(synapse2));
5454

55-
// synapse1 should not equal synapse 2 because synapse1's
55+
// synapse1 should not equal synapse2 because synapse1's
5656
// synapseIndex != synapse2's synapseIndex
5757
synapse1 = new Synapse(cell1, segment1, 0, 0);
5858
synapse2 = new Synapse(cell1, segment1, 1, 0);
5959
assertFalse(synapse1.equals(synapse2));
6060

61+
// synapse1 should not equal synapse2 because synapse1's
62+
// permanence != synapse2's permanence
63+
synapse1 = new Synapse(cell1, segment1, 0, 0);
64+
synapse2 = new Synapse(cell1, segment1, 0, 1);
65+
assertFalse(synapse1.equals(synapse2));
66+
6167
// synapse1 should equal synapse2 because all of their
6268
// relevant properties are equal
6369
synapse1 = new Synapse(cell1, segment1, 0, 0);

0 commit comments

Comments
 (0)