Skip to content

Commit 0e73316

Browse files
committed
Comment out unreachable test case for non-concrete tuple
The test attempting to create a non-concrete tuple cannot actually test the unreachable else branch (line 69 in dense.jl). The type annotation ::Tuple{Any, Any} does not change the actual runtime type, so typeof() still returns a concrete type. This aligns with the previous commit that commented out the unreachable code paths in the implementation.
1 parent 00e9062 commit 0e73316

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

test/test_MeshArrays.jl

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,12 @@ end
105105
@test isconcretetype(typeof(stabilized))
106106
@test stabilized === mesh_tuple
107107

108-
non_concrete_tuple = tuple(mesh1, mesh2)::Tuple{Any, Any}
109-
stabilized_non_concrete = MeshArrays._stabilize_mesh_type(non_concrete_tuple)
110-
@test isconcretetype(typeof(stabilized_non_concrete))
108+
# NOTE: Cannot test the non-concrete tuple branch (line 69 in dense.jl) because
109+
# typeof() always returns the actual runtime type, which is concrete. The type
110+
# annotation ::Tuple{Any, Any} does not change the actual type of the tuple.
111+
# non_concrete_tuple = tuple(mesh1, mesh2)::Tuple{Any, Any}
112+
# stabilized_non_concrete = MeshArrays._stabilize_mesh_type(non_concrete_tuple)
113+
# @test isconcretetype(typeof(stabilized_non_concrete))
111114

112115
non_concrete_mesh = Any[mesh1, mesh2]
113116
stabilized_from_vec = MeshArrays._stabilize_mesh_type(non_concrete_mesh)

0 commit comments

Comments
 (0)