Skip to content

Commit 057fbc7

Browse files
committed
only warn on dimemas failure
1 parent 7dde356 commit 057fbc7

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

pypop/trace/prvtrace.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
),
3030
"Total Runtime": (
3131
"../cfgs/total_runtime_excl_disabled.cfg",
32-
"../cfgs/total_runtime.cfg",),
32+
"../cfgs/total_runtime.cfg",
33+
),
3334
"Useful Instructions": ("../cfgs/useful_instructions.cfg",),
3435
"Useful Cycles": ("../cfgs/useful_cycles.cfg",),
3536
}.items()
@@ -237,8 +238,13 @@ def _analyze_tracefile(trace, chop_to_roi, outpath):
237238
stats["Total Non-MPI Runtime"].loc[:, 1].max()
238239
> stats["Ideal Runtime"].loc[:, 1].max()
239240
):
240-
raise RuntimeError(
241-
"Illegal Ideal Runtime value (less than useful computation)"
241+
warn(
242+
"Dimemas has provided an invalid Ideal Runtime value (less than Useful "
243+
"Computation)\ntracefile:{}\nIR:{}\nUC:{}".format(
244+
trace,
245+
stats["Total Non-MPI Runtime"].loc[:, 1].max(),
246+
stats["Ideal Runtime"].loc[:, 1].max(),
247+
)
242248
)
243249

244250
return stats

0 commit comments

Comments
 (0)