check if user already exist

Author: rinaldo stevenazzi

constants/events.js

@@ -0,0 +1,7 @@
+
+module.exports  = Object.freeze({
+    USER_ALREADY_EXIST: 'userAlreadyExist',
+    USER_CREATED: 'userCreated',
+    REMOVE_USER: 'removeUser'
+})
+

constants/scores.js

@@ -1,6 +1,7 @@
 const MongoDB = require("../services/MongoDB")
 const Users = require("../services/Users");
 const Scores = require("../services/Scores");
+const EVENTS = require("../constants/events");
 
 class Global {
     constructor(){
@@ -29,12 +30,16 @@ class Global {
         })
     }
 
-    addUser (score, email, password) {
-        return new Promise((resolve, reject) => {
+     addUser (score, email, password) {
+        return new Promise(async (resolve, reject) => {
+            const oldUser =  await this.users.isUserAlreadyExist(email)
+            if (oldUser) {
+                resolve({message: EVENTS.USER_ALREADY_EXIST})
+            }
+
             this.users.addUser({score, email, password})
-                .then(() => {
-                    console.log('Global Controller - addUser')
-                    resolve()
+                .then((result) => {
+                    resolve({message: EVENTS.USER_CREATED})
                 }).catch(e => {
                 console.log('Global Controller - addUser failed !!!')
                 reject()

controllers/Global.js

@@ -2,6 +2,7 @@ const express = require('express');
 const http = require('http')
 require('dotenv').config()
 const Global = require('./Controllers/Global')
+const EVENTS = require("./constants/events");
 
 const app = express()
 const server = http.createServer(app)
@@ -34,8 +35,11 @@ app.post('/adduser', (req, res) => {
     // console.log('globalController - /adduser score', score)
     // console.log('globalController - /adduser email', email)
     // console.log('globalController - /adduser password', password)
-    globalController.addUser(score, email, password).then(() => {
-        console.log('index - response 200')
+    globalController.addUser(score, email, password).then((result) => {
+        console.log('index - adduser result', result)
+        if (result.message === EVENTS.USER_ALREADY_EXIST) {
+            res.status(409).send("User Already Exist.")
+        }
         res.send()
     }).catch((result) => {
         console.log('index - response 406')

index.js

@@ -13,12 +13,16 @@ class Users {
         this.collection = collection.collection("users")
     }
 
+    async isUserAlreadyExist (email) {
+       return  await this.collection.findOne({ email });
+    }
+
     addUser (user) {
         return new Promise((resolve, reject) => {
             this.collection.insertOne(user)
-                .then(() => {
-                    console.log('Users - addUser')
-                    resolve(null)
+                .then((result) => {
+                    console.log('Users - addUser', result)
+                    resolve(result)
                 })
                 .catch(e => {
                     console.log('Users - addUser failed !!!')