gnome.mkenums: Use rspfiles on Windows when possible

Fixes mesonbuild#6710

(cherry picked from commit 49c462b)

Author: amyspark

mesonbuild/backend/backends.py

@@ -29,7 +29,7 @@
     File, MachineChoice, MesonException, MesonBugException, OrderedSet,
     ExecutableSerialisation, EnvironmentException,
     classify_unity_sources, get_compiler_for_source,
-    is_parent_path,
+    is_parent_path, get_rsp_threshold,
 )
 from ..options import OptionKey
 
@@ -533,6 +533,7 @@ def get_executable_serialisation(
             capture: T.Optional[str] = None,
             feed: T.Optional[str] = None,
             env: T.Optional[mesonlib.EnvironmentVariables] = None,
+            can_use_rsp_file: bool = False,
             tag: T.Optional[str] = None,
             verbose: bool = False,
             installdir_map: T.Optional[T.Dict[str, str]] = None) -> 'ExecutableSerialisation':
@@ -594,6 +595,21 @@ def get_executable_serialisation(
             exe_wrapper = None
 
         workdir = workdir or self.environment.get_build_dir()
+
+        # Must include separators as well
+        needs_rsp_file = can_use_rsp_file and sum(len(i) + 1 for i in cmd_args) >= get_rsp_threshold()
+
+        if needs_rsp_file:
+            hasher = hashlib.sha1()
+            args = ' '.join(mesonlib.quote_arg(arg) for arg in cmd_args)
+            hasher.update(args.encode(encoding='utf-8', errors='ignore'))
+            digest = hasher.hexdigest()
+            scratch_file = f'meson_rsp_{digest}.rsp'
+            rsp_file = os.path.join(self.environment.get_scratch_dir(), scratch_file)
+            with open(rsp_file, 'w', encoding='utf-8', newline='\n') as f:
+                f.write(args)
+                cmd_args = [f'@{rsp_file}']
+
         return ExecutableSerialisation(exe_cmd + cmd_args, env,
                                        exe_wrapper, workdir,
                                        extra_paths, capture, feed, tag, verbose, installdir_map)
@@ -606,14 +622,15 @@ def as_meson_exe_cmdline(self, exe: T.Union[str, mesonlib.File, build.BuildTarge
                              feed: T.Optional[str] = None,
                              force_serialize: bool = False,
                              env: T.Optional[mesonlib.EnvironmentVariables] = None,
+                             can_use_rsp_file: bool = False,
                              verbose: bool = False) -> T.Tuple[T.List[str], str]:
         '''
         Serialize an executable for running with a generator or a custom target
         '''
         cmd: T.List[T.Union[str, mesonlib.File, build.BuildTarget, build.CustomTarget, programs.ExternalProgram]] = []
         cmd.append(exe)
         cmd.extend(cmd_args)
-        es = self.get_executable_serialisation(cmd, workdir, extra_bdeps, capture, feed, env, verbose=verbose)
+        es = self.get_executable_serialisation(cmd, workdir, extra_bdeps, capture, feed, env, can_use_rsp_file, verbose=verbose)
         reasons: T.List[str] = []
         if es.extra_paths:
             reasons.append('to set PATH')
@@ -653,6 +670,9 @@ def as_meson_exe_cmdline(self, exe: T.Union[str, mesonlib.File, build.BuildTarge
                 envlist.append(f'{k}={v}')
             return ['env'] + envlist + es.cmd_args, ', '.join(reasons)
 
+        if any(a.startswith('@') for a in es.cmd_args):
+            reasons.append('because command is too long')
+
         if not force_serialize:
             if not capture and not feed:
                 return es.cmd_args, ''

mesonbuild/backend/ninjabackend.py

@@ -1224,6 +1224,7 @@ def generate_custom_target(self, target: build.CustomTarget) -> None:
                                                 capture=ofilenames[0] if target.capture else None,
                                                 feed=srcs[0] if target.feed else None,
                                                 env=target.env,
+                                                can_use_rsp_file=target.rspable,
                                                 verbose=target.console)
         if reason:
             cmd_type = f' (wrapped by meson {reason})'

mesonbuild/build.py

@@ -2687,6 +2687,7 @@ def __init__(self,
                  install_dir: T.Optional[T.List[T.Union[str, Literal[False]]]] = None,
                  install_mode: T.Optional[FileMode] = None,
                  install_tag: T.Optional[T.List[T.Optional[str]]] = None,
+                 rspable: bool = False,
                  absolute_paths: bool = False,
                  backend: T.Optional['Backend'] = None,
                  description: str = 'Generating {} with a custom command',
@@ -2719,6 +2720,9 @@ def __init__(self,
         # Whether to use absolute paths for all files on the commandline
         self.absolute_paths = absolute_paths
 
+        # Whether to enable using response files for the underlying tool
+        self.rspable = rspable
+
     def get_default_install_dir(self) -> T.Union[T.Tuple[str, str], T.Tuple[None, None]]:
         return None, None
 

mesonbuild/modules/gnome.py

@@ -1991,6 +1991,7 @@ def _make_mkenum_impl(
             extra_depends=depends,
             # https://github.com/mesonbuild/meson/issues/973
             absolute_paths=True,
+            rspable=mesonlib.is_windows() or mesonlib.is_cygwin(),
             description='Generating GObject enum file {}',
         )