QuadDtype -> bool cast is wrong

[juntyr]

In

https://github.com/numpy/numpy-user-dtypes/blob/48260301b3d01a209469e1ff838ace50f5e00e06/quaddtype/src/csrc/casts.cpp#L1214-L1224

we cast SLEEF quad to int and then check if the result is non-zero. This means that small non-zero values, which are also cast to integer zero, count as Falsy, even though they should be True. We should instead compare with SLEEF zero

[SwayamInSync]

Lets solve it on the new repo, https://github.com/numpy/numpy-quaddtype
Can you please shift this and the doc PR there as well

[SwayamInSync]

oh wait, I can transfer, no worries

[SwayamInSync]

In

numpy/numpy-user-dtypes@4826030/quaddtype/src/csrc/casts.cpp#L1214-L1224

we cast SLEEF quad to int and then check if the result is non-zero. This means that small non-zero values, which are also cast to integer zero, count as Falsy, even though they should be True. We should instead compare with SLEEF zero

Good catch, just comparing in float domain should be correct