Skip to content

Commit 0c4926b

Browse files
committed
make a little friendlier to subclasses
1 parent 5f447e5 commit 0c4926b

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

stringdtype/stringdtype/src/dtype.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -483,9 +483,8 @@ static PyMemberDef StringDType_members[] = {
483483
static PyObject *
484484
StringDType_richcompare(PyObject *self, PyObject *other, int op)
485485
{
486-
// this isn't very friendly to subclasses
487486
if (!((op == Py_EQ) || (op == Py_NE)) ||
488-
(Py_TYPE(other) != (PyTypeObject *)&StringDType)) {
487+
(Py_TYPE(other) != Py_TYPE(self))) {
489488
Py_INCREF(Py_NotImplemented);
490489
return Py_NotImplemented;
491490
}

0 commit comments

Comments
 (0)