change here

Author: SwayamInSync

quaddtype/numpy_quaddtype/src/casts.cpp

@@ -181,12 +181,21 @@ unicode_to_quad_resolve_descriptors(PyObject *NPY_UNUSED(self), PyArray_DTypeMet
                                     PyArray_Descr *given_descrs[2], PyArray_Descr *loop_descrs[2],
                                     npy_intp *view_offset)
 {
-    Py_INCREF(given_descrs[0]);
-    loop_descrs[0] = given_descrs[0];
+    if (!PyArray_ISNBO(given_descrs[0]->byteorder)) {
+        loop_descrs[0] = PyArray_DescrNewByteorder(given_descrs[0], NPY_NATIVE);
+        if (loop_descrs[0] == nullptr) {
+            return (NPY_CASTING)-1;
+        }
+    }
+    else {
+        Py_INCREF(given_descrs[0]);
+        loop_descrs[0] = given_descrs[0];
+    }
 
     if (given_descrs[1] == NULL) {
         loop_descrs[1] = (PyArray_Descr *)new_quaddtype_instance(BACKEND_SLEEF);
         if (loop_descrs[1] == nullptr) {
+            Py_DECREF(loop_descrs[0]);
             return (NPY_CASTING)-1;
         }
     }

quaddtype/tests/test_quaddtype.py

@@ -601,7 +601,20 @@ def test_cast_string_to_quad_roundtrip(self, input_val, strtype):
 
 class TestStringParsingEdgeCases:
     """Test edge cases in NumPyOS_ascii_strtoq string parsing"""
-    
+    @pytest.mark.parametrize("input_str", ['3.14', '-2.71', '0.0', '1e10', '-1e-10'])
+    @pytest.mark.parametrize("byte_order", ['<', '>'])
+    def test_numeric_string_parsing(self, input_str, byte_order):
+        """Test that numeric strings are parsed correctly regardless of byte order"""
+        strtype = np.dtype(f'{byte_order}U20')
+        arr = np.array([input_str], dtype=strtype)
+        result = arr.astype(QuadPrecDType())
+        
+        expected = np.array(input_str, dtype=np.float64)
+        
+        np.testing.assert_allclose(result, expected,
+                                      err_msg=f"Failed parsing '{input_str}' with byte order '{byte_order}'")
+
+
     @pytest.mark.parametrize("input_str,expected_sign", [
         ("inf", 1),
         ("+inf", 1),