Skip to content

Commit 184efc5

Browse files
authored
Merge pull request #230 from ngoldbaum/fix-build-instructions
2 parents 13d62b1 + d2cbdb4 commit 184efc5

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

quaddtype/README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,11 @@ Building the `numpy-quaddtype` package:
4242
python3 -m venv temp
4343
source temp/bin/activate
4444

45-
# Install the package
46-
pip install numpy pytest
45+
# Install NumPy from source
46+
pip install "numpy @ git+https://github.com/numpy/numpy.git"
47+
48+
# Install build and test dependencies
49+
pip install pytest meson meson-python
4750

4851
# To build without QBLAS (default for MSVC)
4952
# export CFLAGS="-DDISABLE_QUADBLAS"

quaddtype/meson.build

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,23 +50,23 @@ if sleef_dep.found() and sleef_dep.type_name() != 'internal'
5050
)
5151
use_system_sleef = true
5252
else
53-
fallback_reason = 'quad-precision support is not working'
53+
fallback_reason = 'System-wide SLEEF installation found but a test for quad precision support failed.'
5454
endif
5555
else
56-
fallback_reason = 'sleefquad library is missing'
56+
fallback_reason = 'System-wide SLEEF installation does not have a sleefquad library.'
5757
endif
5858
else
59-
fallback_reason = 'SLEEF not found system-wide'
59+
fallback_reason = 'Cannot find system-wide SLEEF installation.'
6060
endif
6161

6262
if use_system_sleef
6363
message('Using system-wide SLEEF installation with quad-precision support')
6464
else
65-
warning('Falling back to SLEEF subproject: ' + fallback_reason)
6665
sleef_subproj = subproject('sleef')
6766
sleef_dep = sleef_subproj.get_variable('sleef_dep')
6867
sleefquad_dep = sleef_subproj.get_variable('sleefquad_dep')
69-
message('Using SLEEF subproject')
68+
warning(fallback_reason)
69+
message('Proceeding with vendored SLEEF subproject instead')
7070
endif
7171

7272
incdir_numpy = run_command(py,

0 commit comments

Comments
 (0)