Skip to content

Commit 325cacd

Browse files
committed
clear error if pandas isn't importable, test without pandas installed
1 parent 30a0b3a commit 325cacd

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Install build and test dependencies
2020
run: |
2121
pip install -i https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy
22-
python -m pip install -U pip build pytest unyt wheel meson ninja meson-python patchelf
22+
python -m pip install -U pip build pytest unyt wheel meson ninja meson-python patchelf pandas
2323
- name: Install asciidtype
2424
working-directory: asciidtype
2525
run: |
@@ -78,3 +78,5 @@ jobs:
7878
working-directory: stringdtype
7979
run: |
8080
ASAN_OPTIONS=detect_leaks=false LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/11/libasan.so pytest -s -vvv --color=yes
81+
pip uninstall pandas
82+
ASAN_OPTIONS=detect_leaks=false LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/11/libasan.so pytest -s -vvv --color=yes

stringdtype/stringdtype/src/dtype.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -600,6 +600,7 @@ init_string_dtype(void)
600600
}
601601
else {
602602
PandasStringDType = StringDType;
603+
PyErr_Clear();
603604
}
604605

605606
for (int i = 0; casts[i] != NULL; i++) {

0 commit comments

Comments
 (0)