remove reconstruct dtype functions made unnecessary by upstream fixes

Author: ngoldbaum

asciidtype/asciidtype/__init__.py

@@ -7,14 +7,7 @@
 from .scalar import ASCIIScalar  # isort: skip
 from ._asciidtype_main import ASCIIDType
 
-
-def _reconstruct_ASCIIDType(*args):
-    # this is needed for pickling instances because numpy overrides the pickling
-    # behavior of the DTypeMeta class using copyreg. By pickling a wrapper
-    # around the ASCIIDType initializer, we avoid triggering the code in numpy
-    # that tries to handle pickling DTypeMeta instances. See
-    # https://github.com/numpy/numpy/issues/23135#issuecomment-1410967842
-    return ASCIIDType(*args)
-
-
-__all__ = ["ASCIIDType", "ASCIIScalar", "_reconstruct_ASCIIDType"]
+__all__ = [
+    "ASCIIDType",
+    "ASCIIScalar",
+]

asciidtype/asciidtype/src/dtype.c

@@ -244,7 +244,7 @@ asciidtype__reduce__(ASCIIDTypeObject *self)
         return NULL;
     }
 
-    obj = PyObject_GetAttrString(mod, "_reconstruct_ASCIIDType");
+    obj = PyObject_GetAttrString(mod, "ASCIIDType");
     Py_DECREF(mod);
     if (obj == NULL) {
         Py_DECREF(ret);

stringdtype/stringdtype/__init__.py

@@ -5,6 +5,7 @@
 from .scalar import StringScalar  # isort: skip
 from ._main import StringDType, _memory_usage
 
+
 __all__ = [
     "StringDType",
     "StringScalar",

stringdtype/stringdtype/src/dtype.c

@@ -204,7 +204,7 @@ stringdtype_repr(StringDTypeObject *NPY_UNUSED(self))
 static int PICKLE_VERSION = 1;
 
 static PyObject *
-stringdtype__reduce__(StringDTypeObject *self)
+stringdtype__reduce__(StringDTypeObject *NPY_UNUSED(self))
 {
     PyObject *ret, *mod, *obj, *state;
 
@@ -219,7 +219,7 @@ stringdtype__reduce__(StringDTypeObject *self)
         return NULL;
     }
 
-    obj = PyObject_GetAttrString(mod, "_reconstruct_StringDType");
+    obj = PyObject_GetAttrString(mod, "StringDType");
     Py_DECREF(mod);
     if (obj == NULL) {
         Py_DECREF(ret);