Skip to content

Commit b38c791

Browse files
authored
Merge pull request #45 from ngoldbaum/fix-memory-leak
Fix memory leak in _memory_usage
2 parents 2f95075 + d248107 commit b38c791

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

stringdtype/stringdtype/src/dtype.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ stringdtype_new(PyTypeObject *NPY_UNUSED(cls), PyObject *args, PyObject *kwds)
255255
static void
256256
stringdtype_dealloc(StringDTypeObject *self)
257257
{
258-
// Need to deallocate all the memory allocated during setitem.
259-
260258
PyArrayDescr_Type.tp_dealloc((PyObject *)self);
261259
}
262260

stringdtype/stringdtype/src/main.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ _memory_usage(PyObject *NPY_UNUSED(self), PyObject *obj)
6464

6565
} while (iternext(iter));
6666

67+
NpyIter_Deallocate(iter);
68+
6769
PyObject *ret = PyLong_FromSize_t(memory_usage);
6870

6971
return ret;

0 commit comments

Comments
 (0)