Skip to content

Commit c5198d1

Browse files
committed
disabling qblas for windows; MSVC incompatibility
1 parent abf0224 commit c5198d1

File tree

2 files changed

+400
-26
lines changed

2 files changed

+400
-26
lines changed

.github/workflows/build_wheels.yml

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ jobs:
145145
path: ./quaddtype/wheelhouse/*.whl
146146
name: wheels-${{ matrix.os }}
147147

148+
# disabling QBLAS optimization for windows due to incompatibility with MSVC
148149
build_wheels_windows:
149150
name: Build wheels on Windows
150151
runs-on: windows-latest
@@ -206,8 +207,8 @@ jobs:
206207
INCLUDE="C:/sleef/include;{project}/numpy_quaddtype/QBLAS/include;$INCLUDE"
207208
LIB="C:/sleef/lib;$LIB"
208209
PATH="C:/sleef/bin;$PATH"
209-
CFLAGS="/IC:/sleef/include /I{project}/numpy_quaddtype/QBLAS/include $CFLAGS"
210-
CXXFLAGS="/IC:/sleef/include /I{project}/numpy_quaddtype/QBLAS/include $CXXFLAGS"
210+
CFLAGS="/IC:/sleef/include /I{project}/numpy_quaddtype/QBLAS/include /DDISABLE_QUADBLAS $CFLAGS"
211+
CXXFLAGS="/IC:/sleef/include /I{project}/numpy_quaddtype/QBLAS/include /DDISABLE_QUADBLAS $CXXFLAGS"
211212
LDFLAGS="C:/sleef/lib/sleef.lib C:/sleef/lib/sleefquad.lib $LDFLAGS"
212213
CIBW_REPAIR_WHEEL_COMMAND: 'delvewheel repair -w {dest_dir} {wheel} --add-path C:\sleef\bin'
213214
CIBW_TEST_COMMAND: |
@@ -226,26 +227,26 @@ jobs:
226227
path: ./quaddtype/wheelhouse/*.whl
227228
name: wheels-windows-${{ matrix.architecture }}
228229

229-
# publish_to_pypi:
230-
# name: Publish to PyPI
231-
# needs: [build_wheels_linux, build_wheels_macos, build_wheels_windows]
232-
# runs-on: ubuntu-latest
233-
# if: startsWith(github.ref, 'refs/tags/quaddtype-v')
234-
235-
# environment:
236-
# name: quadtype_release
237-
# url: https://pypi.org/p/numpy-quaddtype
238-
239-
# permissions:
240-
# id-token: write # IMPORTANT: mandatory for trusted publishing
241-
242-
# steps:
243-
# - name: Download all workflow run artifacts
244-
# uses: actions/download-artifact@v4
245-
# with:
246-
# path: dist
247-
248-
# - name: Publish to PyPI
249-
# uses: pypa/gh-action-pypi-publish@release/v1
250-
# with:
251-
# packages-dir: dist/*
230+
publish_to_pypi:
231+
name: Publish to PyPI
232+
needs: [build_wheels_linux, build_wheels_macos, build_wheels_windows]
233+
runs-on: ubuntu-latest
234+
if: startsWith(github.ref, 'refs/tags/quaddtype-v')
235+
236+
environment:
237+
name: quadtype_release
238+
url: https://pypi.org/p/numpy-quaddtype
239+
240+
permissions:
241+
id-token: write # IMPORTANT: mandatory for trusted publishing
242+
243+
steps:
244+
- name: Download all workflow run artifacts
245+
uses: actions/download-artifact@v4
246+
with:
247+
path: dist
248+
249+
- name: Publish to PyPI
250+
uses: pypa/gh-action-pypi-publish@release/v1
251+
with:
252+
packages-dir: dist/*

0 commit comments

Comments
 (0)