Skip to content

Commit ce88bdc

Browse files
committed
add comment explaining why we don't have casts for remaining numpy numeric dtypes
1 parent 7b65591 commit ce88bdc

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

stringdtype/stringdtype/src/casts.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -904,6 +904,18 @@ STRING_TO_FLOAT_RESOLVE_DESCRIPTORS(float16, HALF)
904904
STRING_TO_FLOAT_CAST(float16, f16, npy_half_isinf, npy_double_to_half)
905905
FLOAT_TO_STRING_CAST(float16, f16, npy_half_to_double)
906906

907+
// TODO: longdouble
908+
// punting on this one because numpy's C routines for handling
909+
// longdouble are not public (specifically NumPyOS_ascii_strtold)
910+
// also this type is kinda niche and is not needed by pandas
911+
//
912+
// cfloat, cdouble, and clongdouble
913+
// not hard to do in principle but not needed by pandas.
914+
//
915+
// datetime
916+
// numpy's utilities for parsing a string into a datetime
917+
// are not public (specifically parse_iso_8601_datetime).
918+
907919
PyArrayMethod_Spec *
908920
get_cast_spec(const char *name, NPY_CASTING casting,
909921
NPY_ARRAYMETHOD_FLAGS flags, PyArray_DTypeMeta **dtypes,

0 commit comments

Comments
 (0)