test(test_validate_hook.py): Added correct pyproject.toml and setup.cfg test cases for the exclude_files option

Author: mattgebert

numpydoc/tests/hooks/test_validate_hook.py

@@ -139,45 +139,6 @@ def test_validate_hook_with_toml_config(example_module, tmp_path, capsys):
     assert capsys.readouterr().err.strip() == expected
 
 
-@pytest.mark.parametrize(
-    "regex, expected_code",
-    [(""".*/example.*\.py""", 0), (""".*/non_existent_match.*\.py""", 1)],
-)
-def test_validate_hook_with_toml_config_exclude_files(
-    example_module, regex, expected_code, tmp_path, capsys
-):
-    """
-    Test that a file is correctly processed in the absence of config files
-    with command line ignore options.
-    """
-
-    with open(tmp_path / "pyproject.toml", "w") as config_file:
-        config_file.write(
-            inspect.cleandoc(
-                """
-                [tool.numpydoc_validation]
-                checks = [
-                    "all",
-                    "EX01",
-                    "SA01",
-                    "ES01",
-                ]
-                exclude = '\\.__init__$'
-                override_SS05 = [
-                    '^Creates',
-                ]
-                exclude_files = [
-                """
-                + regex
-                + """]
-                """
-            )
-        )
-
-    return_code = run_hook([example_module], config=tmp_path)
-    assert return_code == expected_code  # Should not-report/report findings.
-
-
 def test_validate_hook_with_setup_cfg(example_module, tmp_path, capsys):
     """
     Test that a file is correctly processed with the config coming from
@@ -285,3 +246,69 @@ def test_validate_hook_exclude_option_setup_cfg(example_module, tmp_path, capsys
     return_code = run_hook([example_module], config=tmp_path)
     assert return_code == 1
     assert capsys.readouterr().err.strip() == expected
+
+
+@pytest.mark.parametrize(
+    "regex, expected_code",
+    [(".*(/|\\\\)example.*\.py", 0), (".*/non_existent_match.*\.py", 1)],
+)
+def test_validate_hook_exclude_files_option_pyproject(
+    example_module, regex, expected_code, tmp_path
+):
+    """
+    Test that the hook correctly processes the toml config and either includes
+    or excludes files based on the `exclude_files` option.
+    """
+
+    with open(tmp_path / "pyproject.toml", "w") as config_file:
+        config_file.write(
+            inspect.cleandoc(
+                f"""
+                [tool.numpydoc_validation]
+                checks = [
+                    "all",
+                    "EX01",
+                    "SA01",
+                    "ES01",
+                ]
+                exclude = '\\.__init__$'
+                override_SS05 = [
+                    '^Creates',
+                ]
+                exclude_files = [
+                    '{regex}',
+                ]"""
+            )
+        )
+
+    return_code = run_hook([example_module], config=tmp_path)
+    assert return_code == expected_code  # Should not-report/report findings.
+
+
+@pytest.mark.parametrize(
+    "regex, expected_code",
+    [(".*(/|\\\\)example.*\.py", 0), (".*/non_existent_match.*\.py", 1)],
+)
+def test_validate_hook_exclude_files_option_setup_cfg(
+    example_module, regex, expected_code, tmp_path
+):
+    """
+    Test that the hook correctly processes the setup config and either includes
+    or excludes files based on the `exclude_files` option.
+    """
+
+    with open(tmp_path / "setup.cfg", "w") as config_file:
+        config_file.write(
+            inspect.cleandoc(
+                f"""
+                [tool:numpydoc_validation]
+                checks = all,EX01,SA01,ES01
+                exclude = \\.NewClass$,\\.__init__$
+                override_SS05 = ^Creates
+                exclude_files = {regex}
+                """
+            )
+        )
+
+    return_code = run_hook([example_module], config=tmp_path)
+    assert return_code == expected_code  # Should not-report/report findings.