test(tests\hooks\test_validate_hook.py): Changed constructor validation to use AST ancestry, fixed hook tests and added Windows support for test_utils

Author: mattgebert

numpydoc/tests/hooks/test_utils.py

@@ -23,7 +23,9 @@ def test_find_project_root(tmp_path, request, reason_file, files, expected_reaso
         (tmp_path / reason_file).touch()
 
     if files:
-        expected_dir = Path("/") if expected_reason == "file system root" else tmp_path
+        expected_dir = (
+            Path(tmp_path.anchor) if expected_reason == "file system root" else tmp_path
+        )
         for file in files:
             (tmp_path / file).touch()
     else:

numpydoc/tests/hooks/test_validate_hook.py

@@ -41,6 +41,8 @@ def test_validate_hook(example_module, config, capsys):
 
         numpydoc/tests/hooks/example_module.py:8: EX01 No examples section found
 
+        numpydoc/tests/hooks/example_module.py:11: GL08 The object does not have a docstring
+
         numpydoc/tests/hooks/example_module.py:17: ES01 No extended summary found
 
         numpydoc/tests/hooks/example_module.py:17: PR01 Parameters {'**kwargs'} not documented
@@ -94,6 +96,8 @@ def test_validate_hook_with_ignore(example_module, capsys):
         """
         numpydoc/tests/hooks/example_module.py:4: PR01 Parameters {'name'} not documented
 
+        numpydoc/tests/hooks/example_module.py:11: GL08 The object does not have a docstring
+
         numpydoc/tests/hooks/example_module.py:17: PR01 Parameters {'**kwargs'} not documented
 
         numpydoc/tests/hooks/example_module.py:17: PR07 Parameter "*args" has no description

numpydoc/validate.py

@@ -660,24 +660,20 @@ def validate(obj_name, validator_cls=None, **validator_kwargs):
                 # cls = Validator._load_obj(f"{doc.name[:-9]}.{cls_name}") ## Alternative
                 cls_doc = Validator(get_doc_object(cls))
             elif isinstance(doc, AstValidator):  # Supports class traversal for ASTs.
-                names = doc._name.split(".")
-
-                if len(names) > 2:  # i.e. module.class.__init__
-                    nested_cls_names = names[1:-1]  # class1,class2 etc.
-                    cls_name = names[-2]
-                    filename = doc.source_file_name  # from the AstValidator object
-
-                    # Use AST to find the class node...
-                    with open(filename) as file:
-                        module_node = ast.parse(file.read(), filename)
-
-                    # Recursively find each subclass from the module node.
-                    next_node = module_node
-                    for name in nested_cls_names:
-                        next_node = _find_class_node(next_node, name)
-                    # Get the documentation.
+                ancestry = doc.ancestry
+                if len(ancestry) > 2:  # e.g. module.class.__init__
+                    parent = doc.ancestry[-1]  # Get the parent
+                    cls_name = ".".join(
+                        [
+                            getattr(node, "name", node.__module__)
+                            for node in doc.ancestry
+                        ]
+                    )
                     cls_doc = AstValidator(
-                        ast_node=next_node, filename=filename, obj_name=cls_name
+                        ast_node=parent,
+                        filename=doc.source_file_name,
+                        obj_name=cls_name,
+                        ancestry=doc.ancestry[:-1],
                     )
                 else:
                     # Ignore edge case: __init__ functions that don't belong to a class.