Skip to content

Commit 3749036

Browse files
committed
✅ fix failing ndarray arithmetic binop tests
1 parent f7f2708 commit 3749036

File tree

5 files changed

+243
-384
lines changed

5 files changed

+243
-384
lines changed

src/numpy-stubs/@test/runtime/legacy/arithmetic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ def __rpow__(self, value: Any) -> Object:
271271

272272
# Inplace multiplication
273273

274-
AR_b *= AR_LIKE_b
274+
AR_b *= AR_LIKE_b # type: ignore[arg-type] # mypy bug
275275

276276
AR_u *= AR_LIKE_b
277277
AR_u *= AR_LIKE_u

src/numpy-stubs/@test/static/reject/arithmetic.pyi

Lines changed: 6 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ i4_nd: npt.NDArray[np.int32]
2626

2727
# Array subtraction
2828

29-
# NOTE: mypys `NoReturn` errors are, unfortunately, not that great
30-
_1 = AR_b - AR_LIKE_b # type: ignore[var-annotated]
31-
_2 = AR_LIKE_b - AR_b # type: ignore[var-annotated]
3229
AR_i - b"" # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
3330

3431
AR_f - AR_LIKE_m # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
@@ -88,15 +85,15 @@ AR_i *= AR_LIKE_c # type: ignore[arg-type] # pyright: ignore[reportAssignmentT
8885
AR_i *= AR_LIKE_m # type: ignore[arg-type] # pyright: ignore[reportAssignmentType]
8986

9087
AR_f *= AR_LIKE_c # type: ignore[arg-type] # pyright: ignore[reportAssignmentType]
91-
AR_f *= AR_LIKE_m # type: ignore[arg-type] # pyright: ignore[reportAssignmentType]
88+
AR_f *= AR_LIKE_m # type: ignore[arg-type] # pyright: ignore[reportOperatorIssue, reportUnknownVariableType]
9289

9390
# Array power
9491

95-
AR_b **= AR_LIKE_b # type: ignore[misc] # pyright: ignore[reportAssignmentType]
96-
AR_b **= AR_LIKE_u # type: ignore[misc] # pyright: ignore[reportAssignmentType]
97-
AR_b **= AR_LIKE_i # type: ignore[misc] # pyright: ignore[reportAssignmentType]
98-
AR_b **= AR_LIKE_f # type: ignore[misc] # pyright: ignore[reportAssignmentType]
99-
AR_b **= AR_LIKE_c # type: ignore[misc] # pyright: ignore[reportAssignmentType]
92+
AR_b **= AR_LIKE_b # type: ignore[arg-type] # pyright: ignore[reportOperatorIssue, reportUnknownVariableType]
93+
AR_b **= AR_LIKE_u # type: ignore[arg-type] # pyright: ignore[reportOperatorIssue, reportUnknownVariableType]
94+
AR_b **= AR_LIKE_i # type: ignore[arg-type] # pyright: ignore[reportAssignmentType]
95+
AR_b **= AR_LIKE_f # type: ignore[arg-type] # pyright: ignore[reportAssignmentType]
96+
AR_b **= AR_LIKE_c # type: ignore[arg-type] # pyright: ignore[reportAssignmentType]
10097

10198
AR_u **= AR_LIKE_f # type: ignore[arg-type] # pyright: ignore[reportAssignmentType]
10299
AR_u **= AR_LIKE_c # type: ignore[arg-type] # pyright: ignore[reportAssignmentType]
@@ -106,21 +103,6 @@ AR_i **= AR_LIKE_c # type: ignore[arg-type] # pyright: ignore[reportAssignment
106103

107104
AR_f **= AR_LIKE_c # type: ignore[arg-type] # pyright: ignore[reportAssignmentType]
108105

109-
# Scalars
110-
111-
b_ - b_ # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
112-
113-
dt + dt # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
114-
td - dt # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
115-
td % 1 # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
116-
td / dt # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
117-
td % dt # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
118-
119-
-b_ # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
120-
+b_ # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
121-
122-
# Scalar and array
123-
124106
# will raise `TypeError` at runtime
125107
u8 << i4_nd # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
126108
u8 >> i4_nd # type: ignore[operator] # pyright: ignore[reportOperatorIssue]

0 commit comments

Comments
 (0)