Minor comments based on review

(1) Add meson flag to build with std threads to ASAN tests
(2) Remove unnecessary comments

Author: Raghuveer Devulapalli

.github/workflows/c-cpp.yml

@@ -165,7 +165,7 @@ jobs:
         CXX: clang++-18
       run: |
         make clean
-        meson setup -Dbuild_tests=true -Duse_openmp=true -Db_sanitize=address,undefined -Dfatal_sanitizers=true  -Dasan_ci_dont_validate=true -Db_lundef=false --warnlevel 0 --buildtype release builddir
+        meson setup -Dbuild_tests=true -Duse_openmp=true -Duse_stdthreads=true -Db_sanitize=address,undefined -Dfatal_sanitizers=true  -Dasan_ci_dont_validate=true -Db_lundef=false --warnlevel 0 --buildtype release builddir
         cd builddir
         ninja
 
@@ -202,7 +202,7 @@ jobs:
         CXX: clang++-18
       run: |
         make clean
-        meson setup -Dbuild_tests=true -Duse_openmp=true -Db_sanitize=address,undefined -Dfatal_sanitizers=true  -Dasan_ci_dont_validate=true -Db_lundef=false --warnlevel 0 --buildtype release builddir
+        meson setup -Dbuild_tests=true -Duse_openmp=true -Duse_stdthreads=true -Db_sanitize=address,undefined -Dfatal_sanitizers=true  -Dasan_ci_dont_validate=true -Db_lundef=false --warnlevel 0 --buildtype release builddir
         cd builddir
         ninja
 

src/xss-common-qsort.h

@@ -752,12 +752,7 @@ X86_SIMD_SORT_INLINE void xss_qsort(T *arr, arrsize_t arrsize, bool hasnan)
 
 #ifdef XSS_BUILD_WITH_STD_THREADS
         bool use_parallel = arrsize > 100000;
-#else
-        bool use_parallel = false;
-#endif
-
         if (use_parallel) {
-#ifdef XSS_BUILD_WITH_STD_THREADS
             // This thread limit was determined experimentally
             constexpr int thread_limit = 8;
             int thread_count = std::min(
@@ -777,13 +772,16 @@ X86_SIMD_SORT_INLINE void xss_qsort(T *arr, arrsize_t arrsize, bool hasnan)
                                                 pool);
             // Wait for all tasks to complete
             pool.wait_all();
-#endif
         }
         else {
             // For small arrays, just use the sequential version
             qsort_<vtype, comparator, T>(
                     arr, 0, arrsize - 1, 2 * (arrsize_t)log2(arrsize), 0);
         }
+#else
+        qsort_<vtype, comparator, T>(
+                arr, 0, arrsize - 1, 2 * (arrsize_t)log2(arrsize), 0);
+#endif // XSS_BUILD_WITH_STD_THREADS
 
         replace_inf_with_nan(arr, arrsize, nan_count, descending);
     }

src/xss-thread-pool.hpp

@@ -37,10 +37,10 @@ namespace tp {
         std::condition_variable
                 done_condition; // Condition variable for waiting
         int active_tasks {0};
-        bool stop;
+        bool stop {false};
 
     public:
-        ThreadPool(size_t num_threads) : stop(false)
+        ThreadPool(size_t num_threads)
         {
             for (size_t i = 0; i < num_threads; ++i) {
                 // Create a worker thread and add it to the pool
@@ -97,15 +97,13 @@ namespace tp {
             done_condition.wait(lock, [this] {
                 return tasks.empty() && (active_tasks == 0);
             });
-            // lock is automatically released here
         }
 
         // Track the number of active tasks
         void task_start()
         {
             std::unique_lock<std::mutex> lock(queue_mutex);
             active_tasks++;
-            // lock is automatically released here
         }
 
         // Decrement the active task count and notify if all tasks are done
@@ -116,7 +114,6 @@ namespace tp {
             if (tasks.empty() && active_tasks == 0) {
                 done_condition.notify_all();
             }
-            // lock is automatically released here
         }
     };