api: standardise image configuration for Cell and Shard

Replaces the standalone `MultiGatewayImage` field in `CellSpec` with a `CellImages` struct to align with the `Shard` resource structure.

Additionally, adds `ImagePullPolicy` and `ImagePullSecrets` to both `CellImages` and `ShardImages`. This allows proper configuration of private registry credentials and pull policies at the Cell and Shard levels.

Author: fernando-villalba

api/v1alpha1/cell_types.go

@@ -17,6 +17,7 @@ limitations under the License.
 package v1alpha1
 
 import (
+	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
@@ -45,9 +46,8 @@ type CellSpec struct {
 	// +kubebuilder:validation:MaxLength=63
 	Region string `json:"region,omitempty"`
 
-	// MultiGatewayImage is the image used for the gateway in this cell.
-	// +kubebuilder:validation:MaxLength=512
-	MultiGatewayImage string `json:"multigatewayImage"`
+	// Images defines the container images used in this cell.
+	Images CellImages `json:"images"`
 
 	// MultiGateway fully resolved config.
 	MultiGateway StatelessSpec `json:"multigateway"`
@@ -69,6 +69,22 @@ type CellSpec struct {
 	TopologyReconciliation TopologyReconciliation `json:"topologyReconciliation,omitempty"`
 }
 
+// CellImages defines the images required for a Cell.
+type CellImages struct {
+	// ImagePullPolicy overrides the default image pull policy.
+	// +optional
+	// +kubebuilder:validation:Enum=Always;Never;IfNotPresent
+	ImagePullPolicy corev1.PullPolicy `json:"imagePullPolicy,omitempty"`
+
+	// ImagePullSecrets is a list of references to secrets in the same namespace.
+	// +optional
+	ImagePullSecrets []corev1.LocalObjectReference `json:"imagePullSecrets,omitempty"`
+
+	// MultiGateway is the image used for the gateway.
+	// +kubebuilder:validation:MaxLength=512
+	MultiGateway string `json:"multigateway"`
+}
+
 // TopologyReconciliation defines flags for the cell controller.
 type TopologyReconciliation struct {
 	// RegisterCell indicates if the cell should register itself in the topology.

api/v1alpha1/shard_types.go

@@ -112,6 +112,15 @@ type ShardSpec struct {
 
 // ShardImages defines the images required for a Shard.
 type ShardImages struct {
+	// ImagePullPolicy overrides the default image pull policy.
+	// +optional
+	// +kubebuilder:validation:Enum=Always;Never;IfNotPresent
+	ImagePullPolicy corev1.PullPolicy `json:"imagePullPolicy,omitempty"`
+
+	// ImagePullSecrets is a list of references to secrets in the same namespace.
+	// +optional
+	ImagePullSecrets []corev1.LocalObjectReference `json:"imagePullSecrets,omitempty"`
+
 	// MultiOrch is the image for the shard orchestrator.
 	// +kubebuilder:validation:MaxLength=512
 	MultiOrch string `json:"multiorch"`