refactor(cluster-handler): update controller to use pointer-based resolver API

The `resolver` package was recently refactored to return pointers for large specification structs (like `StatelessSpec`) instead of returning them by value. This improvement avoids unnecessary copying of data structures and aligns with standard Kubernetes operator patterns.

This commit updates the `MultigresCluster` controller to consume this new API signature:
- Updated `reconcileCells` to handle the pointer return values from `MergeCellConfig`.
- Added necessary dereferencing when assigning the Gateway spec to the Cell CR, ensuring the configuration is correctly applied to the child resources.

Author: fernando-villalba

pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go

@@ -305,7 +305,7 @@ func (r *MultigresClusterReconciler) reconcileCells(
 			cellCR.Spec.Zone = cellCfg.Zone
 			cellCR.Spec.Region = cellCfg.Region
 			cellCR.Spec.MultiGatewayImage = cluster.Spec.Images.MultiGateway
-			cellCR.Spec.MultiGateway = gatewaySpec
+			cellCR.Spec.MultiGateway = *gatewaySpec
 			cellCR.Spec.AllCells = allCellNames
 
 			cellCR.Spec.GlobalTopoServer = globalTopoRef

pkg/resolver/cell.go

@@ -45,13 +45,13 @@ func MergeCellConfig(
 	template *multigresv1alpha1.CellTemplate,
 	overrides *multigresv1alpha1.CellOverrides,
 	inline *multigresv1alpha1.CellInlineSpec,
-) (multigresv1alpha1.StatelessSpec, *multigresv1alpha1.LocalTopoServerSpec) {
-	var gateway multigresv1alpha1.StatelessSpec
+) (*multigresv1alpha1.StatelessSpec, *multigresv1alpha1.LocalTopoServerSpec) {
+	gateway := &multigresv1alpha1.StatelessSpec{}
 	var localTopo *multigresv1alpha1.LocalTopoServerSpec
 
 	if template != nil {
 		if template.Spec.MultiGateway != nil {
-			gateway = *template.Spec.MultiGateway.DeepCopy()
+			gateway = template.Spec.MultiGateway.DeepCopy()
 		}
 		if template.Spec.LocalTopoServer != nil {
 			localTopo = template.Spec.LocalTopoServer.DeepCopy()
@@ -60,12 +60,12 @@ func MergeCellConfig(
 
 	if overrides != nil {
 		if overrides.MultiGateway != nil {
-			mergeStatelessSpec(&gateway, overrides.MultiGateway)
+			mergeStatelessSpec(gateway, overrides.MultiGateway)
 		}
 	}
 
 	if inline != nil {
-		gw := *inline.MultiGateway.DeepCopy()
+		gw := inline.MultiGateway.DeepCopy()
 		var topo *multigresv1alpha1.LocalTopoServerSpec
 		if inline.LocalTopoServer != nil {
 			topo = inline.LocalTopoServer.DeepCopy()

pkg/resolver/cell_test.go

@@ -115,7 +115,7 @@ func TestMergeCellConfig(t *testing.T) {
 		tpl       *multigresv1alpha1.CellTemplate
 		overrides *multigresv1alpha1.CellOverrides
 		inline    *multigresv1alpha1.CellInlineSpec
-		wantGw    multigresv1alpha1.StatelessSpec
+		wantGw    *multigresv1alpha1.StatelessSpec
 		wantTopo  *multigresv1alpha1.LocalTopoServerSpec
 	}{
 		"Full Merge With Resources and Affinity Overrides": {
@@ -145,7 +145,7 @@ func TestMergeCellConfig(t *testing.T) {
 					},
 				},
 			},
-			wantGw: multigresv1alpha1.StatelessSpec{
+			wantGw: &multigresv1alpha1.StatelessSpec{
 				Replicas:       ptr.To(int32(2)),
 				PodAnnotations: map[string]string{"foo": "bar", "baz": "qux"},
 				Resources: corev1.ResourceRequirements{
@@ -166,7 +166,7 @@ func TestMergeCellConfig(t *testing.T) {
 				},
 			},
 			overrides: nil,
-			wantGw:    multigresv1alpha1.StatelessSpec{Replicas: ptr.To(int32(1))},
+			wantGw:    &multigresv1alpha1.StatelessSpec{Replicas: ptr.To(int32(1))},
 		},
 		"Preserve Base (Empty Override)": {
 			tpl: &multigresv1alpha1.CellTemplate{
@@ -180,7 +180,7 @@ func TestMergeCellConfig(t *testing.T) {
 			overrides: &multigresv1alpha1.CellOverrides{
 				MultiGateway: &multigresv1alpha1.StatelessSpec{},
 			},
-			wantGw: multigresv1alpha1.StatelessSpec{
+			wantGw: &multigresv1alpha1.StatelessSpec{
 				Replicas:       ptr.To(int32(1)),
 				PodAnnotations: map[string]string{"foo": "bar"},
 			},
@@ -197,7 +197,7 @@ func TestMergeCellConfig(t *testing.T) {
 					PodLabels:      map[string]string{"c": "d"},
 				},
 			},
-			wantGw: multigresv1alpha1.StatelessSpec{
+			wantGw: &multigresv1alpha1.StatelessSpec{
 				Replicas:       ptr.To(int32(1)),
 				PodAnnotations: map[string]string{"a": "b"},
 				PodLabels:      map[string]string{"c": "d"},
@@ -215,7 +215,7 @@ func TestMergeCellConfig(t *testing.T) {
 					Etcd: &multigresv1alpha1.EtcdSpec{Image: "inline-etcd"},
 				},
 			},
-			wantGw: multigresv1alpha1.StatelessSpec{Replicas: ptr.To(int32(99))},
+			wantGw: &multigresv1alpha1.StatelessSpec{Replicas: ptr.To(int32(99))},
 			wantTopo: &multigresv1alpha1.LocalTopoServerSpec{
 				Etcd: &multigresv1alpha1.EtcdSpec{Image: "inline-etcd"},
 			},
@@ -225,11 +225,11 @@ func TestMergeCellConfig(t *testing.T) {
 			overrides: &multigresv1alpha1.CellOverrides{
 				MultiGateway: &multigresv1alpha1.StatelessSpec{Replicas: ptr.To(int32(2))},
 			},
-			wantGw: multigresv1alpha1.StatelessSpec{Replicas: ptr.To(int32(2))},
+			wantGw: &multigresv1alpha1.StatelessSpec{Replicas: ptr.To(int32(2))},
 		},
 		"Nil Everything": {
 			tpl:      nil,
-			wantGw:   multigresv1alpha1.StatelessSpec{},
+			wantGw:   &multigresv1alpha1.StatelessSpec{},
 			wantTopo: nil,
 		},
 	}