Merge pull request #115 from numtide/add-pvc-rbac-for-backup

Add pvc handling for controller

Author: rytswd

api/v1alpha1/shard_types.go

@@ -35,6 +35,7 @@ import (
 // +kubebuilder:rbac:groups=multigres.com,resources=shards/finalizers,verbs=update
 // +kubebuilder:rbac:groups=apps,resources=deployments;statefulsets,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups="",resources=services,verbs=get;list;watch;create;update;patch;delete
+// +kubebuilder:rbac:groups="",resources=persistentvolumeclaims,verbs=get;list;watch;create;update;patch;delete
 
 // ============================================================================
 // Shard Component Specs (Reusable)
@@ -76,6 +77,14 @@ type PoolSpec struct {
 	// +optional
 	Storage StorageSpec `json:"storage,omitempty"`
 
+	// BackupStorageType defines how backup storage is provided.
+	// Valid values are "hostPath" (for single-node testing) and "pvc" (for production).
+	// Defaults to "hostPath".
+	// +optional
+	// +kubebuilder:validation:Enum=hostPath;pvc
+	// +kubebuilder:default="hostPath"
+	BackupStorageType string `json:"backupStorageType,omitempty"`
+
 	// Postgres container configuration.
 	// +optional
 	Postgres ContainerConfig `json:"postgres,omitempty"`

config/crd/bases/multigres.com_multigresclusters.yaml

@@ -4401,6 +4401,16 @@ spec:
                                                     x-kubernetes-list-type: atomic
                                                 type: object
                                             type: object
+                                          backupStorageType:
+                                            default: hostPath
+                                            description: |-
+                                              BackupStorageType defines how backup storage is provided.
+                                              Valid values are "hostPath" (for single-node testing) and "pvc" (for production).
+                                              Defaults to "hostPath".
+                                            enum:
+                                            - hostPath
+                                            - pvc
+                                            type: string
                                           cells:
                                             description: Cells defines the list of
                                               cells where this Pool should be deployed.
@@ -6669,6 +6679,16 @@ spec:
                                                     x-kubernetes-list-type: atomic
                                                 type: object
                                             type: object
+                                          backupStorageType:
+                                            default: hostPath
+                                            description: |-
+                                              BackupStorageType defines how backup storage is provided.
+                                              Valid values are "hostPath" (for single-node testing) and "pvc" (for production).
+                                              Defaults to "hostPath".
+                                            enum:
+                                            - hostPath
+                                            - pvc
+                                            type: string
                                           cells:
                                             description: Cells defines the list of
                                               cells where this Pool should be deployed.

config/crd/bases/multigres.com_shards.yaml

@@ -2066,6 +2066,16 @@ spec:
                               x-kubernetes-list-type: atomic
                           type: object
                       type: object
+                    backupStorageType:
+                      default: hostPath
+                      description: |-
+                        BackupStorageType defines how backup storage is provided.
+                        Valid values are "hostPath" (for single-node testing) and "pvc" (for production).
+                        Defaults to "hostPath".
+                      enum:
+                      - hostPath
+                      - pvc
+                      type: string
                     cells:
                       description: Cells defines the list of cells where this Pool
                         should be deployed.

config/crd/bases/multigres.com_shardtemplates.yaml

@@ -1982,6 +1982,16 @@ spec:
                               x-kubernetes-list-type: atomic
                           type: object
                       type: object
+                    backupStorageType:
+                      default: hostPath
+                      description: |-
+                        BackupStorageType defines how backup storage is provided.
+                        Valid values are "hostPath" (for single-node testing) and "pvc" (for production).
+                        Defaults to "hostPath".
+                      enum:
+                      - hostPath
+                      - pvc
+                      type: string
                     cells:
                       description: Cells defines the list of cells where this Pool
                         should be deployed.

config/crd/bases/multigres.com_tablegroups.yaml

@@ -2097,6 +2097,16 @@ spec:
                                     x-kubernetes-list-type: atomic
                                 type: object
                             type: object
+                          backupStorageType:
+                            default: hostPath
+                            description: |-
+                              BackupStorageType defines how backup storage is provided.
+                              Valid values are "hostPath" (for single-node testing) and "pvc" (for production).
+                              Defaults to "hostPath".
+                            enum:
+                            - hostPath
+                            - pvc
+                            type: string
                           cells:
                             description: Cells defines the list of cells where this
                               Pool should be deployed.

config/rbac/role.yaml

@@ -7,6 +7,7 @@ rules:
 - apiGroups:
   - ""
   resources:
+  - persistentvolumeclaims
   - services
   verbs:
   - create