Skip to content

Commit df0d535

Browse files
docs(design): standardize image pull config across child resources
This commit updates the `v1alpha1` design document to refactor how images are configured in the child resources (`Cell`, `TableGroup`, `Shard`). **Changes:** * **Structure Alignment:** Replaced the flat `multigatewayImage` field in `Cell` with a structured `images` block, aligning it with `TableGroup` and `Shard`. * **Self-Containment:** Added `imagePullPolicy` and `imagePullSecrets` to the `images` block for all child resources. **Reasoning:** This ensures that Child Controllers are fully autonomous. They no longer need to look up the parent `MultigresCluster` to resolve image pull secrets or policies, making the reconciliation logic simpler and more robust.
1 parent c23f6b2 commit df0d535

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

plans/phase-1/api-design/multigres-operator-api-v1alpha1-design.md

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -681,8 +681,12 @@ spec:
681681
name: "us-east-1a"
682682
zone: "us-east-1a" # this would be region if that was chosen instead.
683683
684-
# Image passed down from global configuration
685-
multigatewayImage: "multigres/multigres:latest"
684+
# Images and pull config passed down from global configuration
685+
images:
686+
imagePullPolicy: "IfNotPresent"
687+
imagePullSecrets:
688+
- name: "my-registry-secret"
689+
multigateway: "multigres/multigres:latest"
686690
687691
# Resolved from CellTemplate + Overrides
688692
multigateway:
@@ -777,10 +781,13 @@ metadata:
777781
spec:
778782
databaseName: "production_db"
779783
tableGroupName: "orders_tg"
780-
default: false
784+
default: true
781785
782-
# Images passed down from global configuration
786+
# Images and pull config passed down from global configuration
783787
images:
788+
imagePullPolicy: "IfNotPresent"
789+
imagePullSecrets:
790+
- name: "my-registry-secret"
784791
multiorch: "multigres/multigres:latest"
785792
multipooler: "multigres/multigres:latest"
786793
postgres: "postgres:15.3"
@@ -940,8 +947,11 @@ spec:
940947
tableGroupName: "orders_tg"
941948
shardName: "0"
942949
943-
# Images passed down from global configuration
950+
# Images and pull config passed down from global configuration
944951
images:
952+
imagePullPolicy: "IfNotPresent"
953+
imagePullSecrets:
954+
- name: "my-registry-secret"
945955
multiorch: "multigres/multigres:latest"
946956
multipooler: "multigres/multigres:latest"
947957
postgres: "postgres:15.3"

0 commit comments

Comments
 (0)