feat: change default verbosity level to error instead of warn

Signed-off-by: Brian McGee <brian@bmcgee.ie>

Author: brianmcgee

cmd/format/format.go

@@ -197,8 +197,8 @@ func Run(v *viper.Viper, statz *stats.Stats, cmd *cobra.Command, paths []string)
 		return fmt.Errorf("failed to close walker: %w", err)
 	}
 
-	// print stats to stdout, unless we are processing from stdin and therefore outputting the results to stdout
-	if !cfg.Stdin {
+	// print stats to stdout unless we are processing from stdin or verbosity level is lower than info (1)
+	if !cfg.Stdin && cfg.Verbose > 0 {
 		statz.Print()
 	}
 

cmd/root.go

@@ -131,8 +131,6 @@ func runE(v *viper.Viper, statz *stats.Stats, cmd *cobra.Command, args []string)
 		return fmt.Errorf("failed to find treefmt config file: %w", err)
 	}
 
-	log.Infof("using config file: %s", configFile)
-
 	// read in the config
 	v.SetConfigFile(configFile)
 
@@ -144,15 +142,21 @@ func runE(v *viper.Viper, statz *stats.Stats, cmd *cobra.Command, args []string)
 	log.SetOutput(os.Stderr)
 	log.SetReportTimestamp(false)
 
+	// set log level based on verbosity
+	// by default we only emit errors
 	switch v.GetInt("verbose") {
 	case 0:
-		log.SetLevel(log.WarnLevel)
+		log.SetLevel(log.ErrorLevel)
 	case 1:
+		log.SetLevel(log.WarnLevel)
+	case 2:
 		log.SetLevel(log.InfoLevel)
 	default:
 		log.SetLevel(log.DebugLevel)
 	}
 
+	log.Infof("using config file: %s", configFile)
+
 	// format
 	return format.Run(v, statz, cmd, args) //nolint:wrapcheck
 }

cmd/root_test.go

@@ -74,7 +74,7 @@ func TestOnUnmatched(t *testing.T) {
 
 	// default is WARN
 	t.Run("default", func(t *testing.T) {
-		treefmt(t, withNoError(t), withOutput(checkOutput(log.WarnLevel)))
+		treefmt(t, withArgs("-v"), withNoError(t), withOutput(checkOutput(log.WarnLevel)))
 	})
 
 	// should exit with error when using fatal
@@ -97,15 +97,15 @@ func TestOnUnmatched(t *testing.T) {
 			as.NoError(err, "failed to parse log level: %s", level)
 
 			treefmt(t,
-				withArgs("-vv", "--on-unmatched", levelStr),
+				withArgs("-vvv", "--on-unmatched", levelStr),
 				withNoError(t),
 				withOutput(checkOutput(level)),
 			)
 
 			t.Setenv("TREEFMT_ON_UNMATCHED", levelStr)
 
 			treefmt(t,
-				withArgs("-vv"),
+				withArgs("-vvv"),
 				withNoError(t),
 				withOutput(checkOutput(level)),
 			)