TestAssemblyResolver not working for .NET 10.0.0 (FindBestVersionDir)

[IRebo]

Im using the current version3 branch and console runner net462 (not netcore).

Trying to run nunit test which references windows forms fails with :

Unable to load one or more of the requested types.
Could not load file or assembly 'System.Windows.Forms, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The system cannot find the file specified.
----> Could not load file or assembly 'System.Windows.Forms, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The system cannot find the file specified.

The reason is that TestAssemblyResolver is refusing to use "C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\10.0.0" for an assembly with version 10.0.0.0.

The function FindBestVersionDir will try to compare new System.Version("10.0.0") >= new System.Version("10.0.0.0") which returns false. Because the revision number in the 10.0.0 is not defined the version is considered lower than any version that has a revision number.

[IRebo]

My hacky solution that works :

if (TryGetVersionFromString(Path.GetFileName(subdir), out version))
{
    Version myTargetVersion = targetVersion;
    if (version.Revision == -1) {
     myTargetVersion = new Version(targetVersion.Major, targetVersion.Minor, targetVersion.Build);
    }

    if (version >= myTargetVersion)
        if (bestVersion.Major == 0 || bestVersion > version)
            bestVersion = version;
}

[CharliePoole]

@IRebo I released 3.22.0 without checking on this one but I think it may be fixed. Can you verify?

[IRebo]

I cant easily test as the dotnet upgraded from 10.0.0 to 10.0.1 so its now comparing 10.0.1 against the 10.0.0.0 reference which works even in the old code. That issue only shows up on new dotnet release like 8.0.0 or 10.0.0.

That said, i dont see the old code in the code base anymore and the new one in FindBestRuntime seems to compare in a better way. So i guess its fixed...

[CharliePoole]

Yes, the new comparison will use the highest available Major+Minor version that is greater than the corresponding Major+Minor you are trying to reference. Exact matches should always occur for a test assembly you just compiled and it's direct references, but not necessarily for indirect references or for tests being run on a different machine.

Feel free to create a new issue if more problems arise. :-)