FIxed a few

OsirisTerje · OsirisTerje · commit 68451e759aa1 · 2025-12-18T14:12:09.000+01:00
diff --git a/Issue1056/UnitTest1.cs b/Issue1056/UnitTest1.cs
@@ -98,7 +98,7 @@ internal class ItemTestCaseData : ITestCaseData
 {
     public ItemTestCaseData(ItemBuilder itemBuilder)
     {
-        Arguments = new object[] { itemBuilder.Item };
+        Arguments = [itemBuilder.Item];
         ExpectedResult = itemBuilder.ExpectedQuality;
         TestName = $"{itemBuilder.Item.Name} with quality {itemBuilder.Item.Quality} to be sold in {itemBuilder.Item.SellIn} days should have quality of {itemBuilder.ExpectedQuality} tomorrow";
     }
diff --git a/Issue1151/Issue1151.csproj b/Issue1151/Issue1151.csproj
@@ -1,7 +1,7 @@
 ﻿<?xml version="1.0" encoding="utf-8"?>
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <LangVersion>latest</LangVersion>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
@@ -18,7 +18,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="NUnit3TestAdapter" Version="5.2.0" />
+    <PackageReference Include="NUnit3TestAdapter" Version="6.0.0" />
   </ItemGroup>
   <ItemGroup>
     <Using Include="NUnit.Framework" />
diff --git a/Issue1713/Issue1713.csproj b/Issue1713/Issue1713.csproj
@@ -1,21 +1,21 @@
 ﻿<?xml version="1.0" encoding="utf-8"?>
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
     <IsTestProject>true</IsTestProject>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
-    <PackageReference Include="NUnit" Version="3.14.0" />
-    <PackageReference Include="NUnit3TestAdapter" Version="4.2.0" />
-    <PackageReference Include="NUnit.Analyzers" Version="3.9.0">
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
+    <PackageReference Include="NUnit" Version="4.4.0" />
+    <PackageReference Include="NUnit3TestAdapter" Version="6.0.0" />
+    <PackageReference Include="NUnit.Analyzers" Version="4.11.2">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="coverlet.collector" Version="6.0.0">
+    <PackageReference Include="coverlet.collector" Version="6.0.4">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
diff --git a/Issue1726/GlobalUsings.cs b/Issue1726/GlobalUsings.cs
diff --git a/Issue1726/Issue1726.csproj b/Issue1726/Issue1726.csproj
diff --git a/Issue1726/Issue1726.sln b/Issue1726/Issue1726.sln
diff --git a/Issue1726/UnitTest1.cs b/Issue1726/UnitTest1.cs
diff --git a/Issue1726/issue_metadata.json b/Issue1726/issue_metadata.json
diff --git a/Issue2466/NUnitIssue2466.csproj b/Issue2466/NUnitIssue2466.csproj
@@ -1,25 +1,22 @@
+﻿<?xml version="1.0" encoding="utf-8"?>
 <Project Sdk="Microsoft.NET.Sdk">
-
   <PropertyGroup>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-
     <IsPackable>false</IsPackable>
   </PropertyGroup>
-
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
-    <PackageReference Include="NUnit" Version="3.13.3" />
-    <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
-    <PackageReference Include="NUnit.Analyzers" Version="3.6.1">
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
+    <PackageReference Include="NUnit" Version="4.4.0" />
+    <PackageReference Include="NUnit3TestAdapter" Version="6.0.0" />
+    <PackageReference Include="NUnit.Analyzers" Version="4.11.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="coverlet.collector" Version="6.0.0">
+    <PackageReference Include="coverlet.collector" Version="6.0.4">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
   </ItemGroup>
-
-</Project>
+</Project>
diff --git a/Issue2466/NUnitIssue2466.sln b/Issue2466/NUnitIssue2466.sln
@@ -1,13 +1,14 @@
 ﻿
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 17
-VisualStudioVersion = 17.5.33627.172
+# Visual Studio Version 18
+VisualStudioVersion = 18.0.11217.181 d18.0
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "NUnitIssue2466", "NUnitIssue2466.csproj", "{F1A46A4A-2FC0-4048-8C84-5365F1453B10}"
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{AF4E4B13-E97F-4730-8805-B3567181DA29}"
 	ProjectSection(SolutionItems) = preProject
 		.runsettings = .runsettings
+		explicit.md = explicit.md
 	EndProjectSection
 EndProject
 Global
diff --git a/Issue2466/UnitTest1.cs b/Issue2466/UnitTest1.cs
@@ -16,10 +16,11 @@ public void Test1()
 
     public void SomeOtherMethod()
     {
-        throw new Exception("SomeOtherMethod");
+        throw new SpecialException("SomeOtherMethod");
     }
 }
 
+public class SpecialException(string someothermethod) : Exception(someothermethod);
 
 public class SqrtTests
 {
diff --git a/Issue2466/explicit.md b/Issue2466/explicit.md
@@ -0,0 +1 @@
+Need a way to check that we get a stacktrace out, and that means we need to capture the whole test like in an isolated workspace. 
diff --git a/Issue2851/Issue2851.csproj b/Issue2851/Issue2851.csproj
@@ -1,14 +1,12 @@
+﻿<?xml version="1.0" encoding="utf-8"?>
 <Project Sdk="Microsoft.NET.Sdk">
-
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net462;net472</TargetFrameworks>
+    <TargetFrameworks>net10.0;net462;net472</TargetFrameworks>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
-
   <ItemGroup>
-	  <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
-	  <PackageReference Include="NUnit" Version="3.13.3" />
-	  <PackageReference Include="NUnit3TestAdapter" Version="4.4.2" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
+    <PackageReference Include="NUnit" Version="4.4.0" />
+    <PackageReference Include="NUnit3TestAdapter" Version="6.0.0" />
   </ItemGroup>
-
-</Project>
+</Project>
diff --git a/TestReport.md b/TestReport.md
@@ -0,0 +1,58 @@
+# Test Report
+
+## Summary
+
+- Regression tests: total 1, success 0, fail 1
+- Open issues: total 0, success 0, fail 0
+
+## What we are testing
+
+Package versions under test:
+
+- NUnit: 4.4.0
+- NUnit.Analyzers: 4.11.2
+- NUnit3TestAdapter: 6.0.0
+
+## Regression tests (closed issues)
+
+- Total: 1, Success: 0, Fail: 1
+
+| Issue | Test | Conclusion |
+| --- | --- | --- |
+| ❗ #1056 | fail | Failure: Regression failure. |
+
+### Closed failures (details)
+
+#### Issue #1056: ITestCaseData does not show test with Visual Studio Test Adapter 3.0.7
+
+**Link**: [#1056](https://github.com/nunit/nunit/issues/1056)
+
+**Labels**: is:bug, closed:duplicate, pri:normal
+
+**Conclusion**: Failure: Regression failure.
+
+**Details**:
+
+```
+Determining projects to restore...
+  Restored C:\repos\nunit\nunit.issues\Issue1056\Issue1056.csproj (in 829 ms).
+C:\repos\nunit\nunit.issues\Issue1056\UnitTest1.cs(81,19): warning CS8618: Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable. [C:\repos\nunit\nunit.issues\Issue1056\Issue1056.csproj]
+C:\repos\nunit\nunit.issues\Issue1056\UnitTest1.cs(99,12): warning CS8618: Non-nullable property 'Properties' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable. [C:\repos\nunit\nunit.issues\Issue1056\Issue1056.csproj]
+  Issue1056 -> C:\repos\nunit\nunit.issues\Issue1056\bin\Debug\net10.0\Issue1056.dll
+Test run for C:\repos\nunit\nunit.issues\Issue1056\bin\Debug\net10.0\Issue1056.dll (.NETCoreApp,Version=v10.0)
+VSTest version 18.0.1 (x64)
+
+Starting test execution, please wait...
+A total of 1 test files matched the specified pattern.
+  Failed TestTheTruth [3 ms]
+  Error Message:
+   Failure building Test
+System.InvalidCastException : Unable to cast object of type 'Issue1056.ItemTestCaseData' to type 'NUnit.Framework.Internal.TestCaseParameters'.
+  Stack Trace:
+     at NUnit.Framework.TestCaseSourceAttribute.BuildFrom(IMethodInfo method, Test suite)+MoveNext()
+   at NUnit.Framework.Internal.Builders.DefaultTestCaseBuilder.BuildFrom(IMethodInfo method, Test parentSuite)
+
+
+Failed!  - Failed:     1, Passed:     0, Skipped:     0, Total:     1, Duration: 3 ms - Issue1056.dll (net10.0)
+```
+
diff --git a/results.json b/results.json
@@ -0,0 +1,28 @@
+[
+  {
+    "number": 548,
+    "project_path": "Issue548.csproj",
+    "project_style": "SDK-style",
+    "target_frameworks": [
+      "net10.0"
+    ],
+    "packages": [
+      "Microsoft.NET.Test.Sdk=17.14.1",
+      "NUnit=4.2.0",
+      "NUnit3TestAdapter=5.2.0",
+      "NUnit.Analyzers=4.11.2",
+      "coverlet.collector=6.0.4"
+    ],
+    "update_result": "success",
+    "update_output": "Discovering projects...\r\nAnalyzing project(s)...\r\nAnalyzing dependencies...\r\nNo outdated dependencies were detected\r\nElapsed: 00:00:03.4676295\r\n",
+    "update_error": "",
+    "test_result": "success",
+    "test_output": "  Determining projects to restore...\r\n  Restored C:\\repos\\nunit\\nunit.issues\\Issue548\\Issue548.csproj (in 527 ms).\r\nC:\\repos\\nunit\\nunit.issues\\Issue548\\Issue1358.cs(13,27): warning CS8602: Dereference of a possibly null reference. [C:\\repos\\nunit\\nunit.issues\\Issue548\\Issue548.csproj]\r\nC:\\repos\\nunit\\nunit.issues\\Issue548\\Issue1358.cs(26,27): warning CS8602: Dereference of a possibly null reference. [C:\\repos\\nunit\\nunit.issues\\Issue548\\Issue548.csproj]\r\n  Issue548 -\u003E C:\\repos\\nunit\\nunit.issues\\Issue548\\bin\\Debug\\net10.0\\Issue548.dll\r\nTest run for C:\\repos\\nunit\\nunit.issues\\Issue548\\bin\\Debug\\net10.0\\Issue548.dll (.NETCoreApp,Version=v10.0)\r\nVSTest version 18.0.1 (x64)\r\n\r\nStarting test execution, please wait...\r\nA total of 1 test files matched the specified pattern.\r\n\r\nPassed!  - Failed:     0, Passed:     7, Skipped:     0, Total:     7, Duration: 58 ms - Issue548.dll (net10.0)\r\n",
+    "test_error": "",
+    "test_conclusion": "Success: No regression failure",
+    "runner_scripts": null,
+    "runsettings": null,
+    "feed": "Stable",
+    "runner_expectations": null
+  }
+]

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ internal class ItemTestCaseData : ITestCaseData`
`98`	`98`	`{`
`99`	`99`	`public ItemTestCaseData(ItemBuilder itemBuilder)`
`100`	`100`	`{`
`101`		`- Arguments = new object[] { itemBuilder.Item };`
	`101`	`+ Arguments = [itemBuilder.Item];`
`102`	`102`	`ExpectedResult = itemBuilder.ExpectedQuality;`
`103`	`103`	`TestName = $"{itemBuilder.Item.Name} with quality {itemBuilder.Item.Quality} to be sold in {itemBuilder.Item.SellIn} days should have quality of {itemBuilder.ExpectedQuality} tomorrow";`
`104`	`104`	`}`